WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#31544 closed defect (bug) (fixed)

Tooltips / Pointers cover theme detail modal in admin

Reported by: krogsgard Owned by: obenland
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.1.1
Component: Themes Keywords: needs-patch
Focuses: administration Cc:

Description

Tooltips or pointers or whatever they are called -- they are covering the modal for the theme detail screen in the WordPress admin. I'm not sure if we should trigger it to be dismissed if ignored, or adjust Z-index of the modal, or what. But it's not very pretty as is.

https://cldup.com/DbZwu7hku6.png

Attachments (3)

31544.diff (683 bytes) - added by obenland 6 years ago.
z-indeces should die in a fire.
31544.2.diff (438 bytes) - added by obenland 6 years ago.
admin-bar-z-index.png (123.7 KB) - added by chris@… 6 years ago.
Admin bar z-index bar

Download all attachments as: .zip

Change History (14)

#1 @obenland
6 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.3

We should look at this.

#2 @obenland
6 years ago

  • Owner set to obenland
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core by obenland. View the logs.


6 years ago

#4 @obenland
6 years ago

#28880 was marked as a duplicate.

@obenland
6 years ago

z-indeces should die in a fire.

#5 @obenland
6 years ago

  • Keywords has-patch added; needs-patch removed

@obenland
6 years ago

#6 @obenland
6 years ago

Another way to deal with it would be to hide the pointer when the modal is open. The modal has a short animation on close, that prohibits the pointer from reappearing until after that animation has finished though, which looks a little awkward.

#7 follow-up: @obenland
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33068:

Don't let wp-pointers cover the theme detail modal.

Fixes #31544.

@chris@…
6 years ago

Admin bar z-index bar

#8 in reply to: ↑ 7 @chris@…
6 years ago

When there's only one theme installed the theme browser only shows the modal without a way to close it. Unfortunately the new z-index is covering up the dropdown menus in the left admin menu.

Admin bar z-index bar

#9 @obenland
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#10 @obenland
6 years ago

  • Keywords needs-patch added; has-patch removed

#11 @obenland
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 33111:

Respect the special case of having only one theme.

If there is only one theme, the Pointer won't show and the overlay is active by
default. In that case the overlay covered submenu flyouts, after [33068].
Without the Pointer active, there is no need to bump the z-index, so it can
remain at 10.

Fixes #31544.

Note: See TracTickets for help on using tickets.