![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 11 years ago
Closed 11 years ago
#31545 closed defect (bug) (fixed)
Comments "hotkeys" tweaks needed after recent changes to table structure
| Reported by: | afercia | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.2 |
| Component: | Comments | Version: | 4.2 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: | ui, javascript |
Description
When using comments "hotkeys" on first load pressing "j" or "k" should highlight the first comment but highlights the second one. Also, when in a second page of paginated comments, pressing "k" on the first comment should bring you back to the first page and highlight the last comment, but the <tfoot> row is highlighted instead.
Broken when moving <tfoot> after <tbody> in r31513 see #30914. Proposed patch uses a more specific selector to target just the table <tbody> rows and adjusts the start_row_index option.
Attachments (1)
Change History (5)
Note:
See TracTickets
for help on using tickets.
31545.patch highlights the first row on 'j' and 'k' exactly as expected. Nice.