Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#31545 closed defect (bug) (fixed)

Comments "hotkeys" tweaks needed after recent changes to table structure

Reported by: afercia's profile afercia Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Comments Keywords: has-patch commit
Focuses: ui, javascript Cc:


When using comments "hotkeys" on first load pressing "j" or "k" should highlight the first comment but highlights the second one. Also, when in a second page of paginated comments, pressing "k" on the first comment should bring you back to the first page and highlight the last comment, but the <tfoot> row is highlighted instead.

Broken when moving <tfoot> after <tbody> in r31513 see #30914. Proposed patch uses a more specific selector to target just the table <tbody> rows and adjusts the start_row_index option.

Attachments (1)

31545.patch (443 bytes) - added by afercia 9 years ago.

Download all attachments as: .zip

Change History (5)

9 years ago

#1 @afercia
9 years ago

  • Keywords has-patch added

#2 @DrewAPicture
9 years ago

  • Milestone changed from Awaiting Review to 4.2

#3 @DrewAPicture
9 years ago

  • Keywords commit added

31545.patch highlights the first row on 'j' and 'k' exactly as expected. Nice.

#4 @SergeyBiryukov
9 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 31929:

Use a more specific selector for comment moderation hotkeys after [31513].

props afercia.
fixes #31545.

Note: See TracTickets for help on using tickets.