number_format_i18n() can cause a PHP notice if $wp_locale is not set

[pauldewouters]

It is possible for number_format_i18n to cause a PHP notice if called via timer_stop at a point where $wp_locale is not set.
This is because the function calls a method of the class without checking if it is available.
I attached a patch.

[DrewAPicture]

Hi Paul, thanks for the patch.

The only issue here is really that the function specifically serves to convert a number based on the locale. So while the is_object() check would solve the problem, I'd be curious to know what your use case is where $wp_locale would not be set.

[pauldewouters]

Drew,

Thanks for your comment. In my case I was calling timer_start() and then timer_stop(1) with some code in between to time it, directly on page load inside a plugin, not inside a hook.
Maybe this was not the expected use case for this function. However, would there not be some benefit to making the function a little more robust?

[helen]

This looks to me like it's existed since the function was introduced, so moving the version accordingly. If this really is a trunk issue somehow, please do let us know, although I don't think it's severe enough to worry about 4.2.

[SergeyBiryukov]

In 35092:

In number_format_i18n(), check if $wp_locale is set before using it.

Props pauldewouters.
Fixes #31553.