Uninitialized var (PHP Notice) in ternary expressions - wp-db.php

[alexkingorg]

I'm not sure the best way to fix this. I've attached a patch that I think should work, but someone should put some serious eyeballs on this one.

[alexkingorg]

patch

[ryan]

(In [4208]) Check if array index is set. Props Alex King. fixes #3156

[donncha]

This caused some weird problems for wpcom - it looked like a cache problem and caused lots of hits on the same queries over and over again. ie.

SELECT option_value FROM wp_options WHERE option_name = 'siteurl' LIMIT 1

repeated about 50 times.

[ryan]

Maybe we need to return false.

[ryan]

Actually, nevermind on that. I'm not seeing why this would make a difference. Weird.

[markjaquith]

Lots of hits on the same queries over and over again can happen if you're using the WP Object Cache (I think you're using a Memcached drop-in on WP.com) and you're querying something that doesn't exist in the DB (like an option).

See #2268

Basically, there's no way to tell the difference between "option isn't in cache" and "option's non-existence has been cached."

This may be related... dunno.

[westi]

Marking this as fixed.

No extra info in nearly a year.

Non-existent options caching went into [4855] which should fix the large number of db queries on cache misses for non-existent options.

Please raise another ticket if you still have issue.