![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Changes between Initial Version and Version 1 of Ticket #31575, comment 7
- Timestamp:
- 03/27/2015 12:33:48 AM (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #31575, comment 7
initial v1 1 1 Replying to [comment:6 stephdau]: 2 2 3 Don't think this approach is good. Currently we have two buttons and two simple JS functions to handle open/close. This is all pretty simple, easy to read, understand, etc. Why should we switch to one complex "dynamic" button with many spans in it and one combined JS function that is longer and harder to read than the two? Also "toggle" usually implies we don't care of the current state much, just want to change it. That's not true in this case though :)3 Don't think this approach is good. Currently we have two buttons and two simple JS functions to handle open/close. This is all pretty simple, easy to read, understand, etc. Why should we switch to one complex "dynamic" button with many spans in it and one combined JS function that is longer and harder to read than the two? I'm not sure if all screen readers are aware of showing/hiding components on the page but having two buttons to control open/close is pretty standard. Also "toggle" usually implies we don't care of the current state much, just want to change it. That's not true in this case though :) 4 4 5 5 If the word "Done" is not enough for screen readers, lets add the "Close post options" screen-reader-text there too. Moving the `aria-expanded` to the panel makes sense. Don't thing it should be on the button as well...
