Opened 11 years ago
Closed 10 years ago
#31588 closed defect (bug) (fixed)
Some params missing docs in `wp_insert_user()`; `$userdata` handled unexpectedly
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 4.3 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Users | Keywords: | has-patch commit |
| Focuses: | Cc: |
Description
The current docs for wp_insert_user() include some parameters no longer accepted by default, and a few other parameters are missing.
The attached patch:
- removes the old default contact methods from the
$userdatahash notation; - adds docs for
$description,$comment_shortcuts,$admin_color,$use_ssl, and$show_admin_bar_front; - fixes a typo in the short description, and generalizes the note in the long description about available filters so it doesn't have to keep up with every new one;
- tries to clarify
$first_nameand$last_name, if I understood them correctly.
The patch also makes a related change to the handling of $comment_shortcuts.
Currently, if $userdata['comment_shortcuts'] = true, the meta value will be 1. But enqueue_comment_hotkeys_js() checks for the string 'true', which is also what edit_user() saves.
With this change, the meta value would be 'true' if $userdata['comment_shortcuts'] is any non-empty value except 'false'.
Attachments (3)
Change History (11)
#2
@
10 years ago
- Keywords needs-refresh added
- Milestone changed from Awaiting Review to Future Release
@
10 years ago
Retains the verbose pre_user_ filter information and updates the exceptions. Also corrects string typo.
#7
@
10 years ago
- Focuses docs removed
- Keywords commit added
- Owner DrewAPicture deleted
- Status changed from accepted to assigned
[32884] took care of updating the documentation portion of 31588.diff.
I split out the code and unit tests changes to 31588.2.diff, which will need code committer review.
Looks like there is still a typo in the word
stringon this line: