WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 5 weeks ago

#31594 closed defect (bug) (fixed)

Labels need uniform spacing on Discussion Settings Page

Reported by: sagarjadhav Owned by: afercia
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch has-screenshots
Focuses: ui Cc:

Description

Labels need uniform spacing on Discussion Settings Page.For Other comment settings section some labels don't have spacing between them. See screenshot attached.

Before changes:

http://i.imgur.com/QDBw5Vc.jpg

After Changes:

http://i.imgur.com/1bbWcea.jpg

Attachments (2)

31594.patch (617 bytes) - added by sagarjadhav 2 years ago.
Fixed the issue
31594.diff (3.6 KB) - added by afercia 5 weeks ago.

Download all attachments as: .zip

Change History (8)

@sagarjadhav
2 years ago

Fixed the issue

#1 @DrewAPicture
2 years ago

  • Component changed from General to Administration
  • Keywords has-patch added

Patch still applies as of r32294.

#2 @swissspidy
5 months ago

  • Keywords has-screenshots needs-refresh added
  • Milestone changed from Awaiting Review to 4.8

For anyone confused by the screenshot: the patch adjusts the left margin of the dropdown inputs.

#3 @SergeyBiryukov
5 months ago

These settings will likely be replaced as a result of the overhaul being done in #39441 and #31354.

#4 @afercia
7 weeks ago

Rather than using CSS and a bit overqualified selector, I'd propose to just print out a space, for consistency with the last setting, where actually the select gets replaced in this string:
Comments should be displayed with the %s comments at the top of each page

For the other ones instead, there are a few occurrences of
</label><label ...
they probably should be
</label> <label ...

@afercia
5 weeks ago

#5 @afercia
5 weeks ago

  • Keywords needs-refresh removed
  • Owner set to afercia
  • Status changed from new to assigned
  • Version 4.1.1 deleted

31594.diff just adds a space between labels. As mentioned above, there's an ongoing effort to introduce further improvements in #39441 and #31354.

#6 @afercia
5 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 40779:

Administration: Use consistent spacing for form elements in the Discussion Settings screen.

Props sagarjadhav.
Fixes #31594.

Note: See TracTickets for help on using tickets.