White space between visual editor content and status bar

[iseulde]

Happens when the 'path' is hidden.

[DrewAPicture]

@iseulde: Care to make a patch for this issue?

[DrewAPicture]

It sounds like the solution is more complicated than a simple style change to remove the white bar. Pretty low priority, punting.

[tyxla]

Is there a reason why visibility: hidden is used here instead of display: none?

Since visibility: hidden is used, the space for the path bar is preserved even when it is hidden. This is what prevents the visual editor to expand and reach the status bar.

Why not just replace visibility: hidden with display: none? No further calculations need to be done IMHO. It seems to be working fine for me on multiple different tests. Here's a patch.

[tyxla]

Replace visibility:hidden with display:none to remove the white space when path is hidden.

Everything seems to be in order.
Applying correctly. Tests coming after.

Trac ticket: https://core.trac.wordpress.org/ticket/31599

[SirLouen]

Combined Bug Reproduction and Test Report

Description

✅This report validates that the indicated patch works as expected.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/9043.diff

Environment

• WordPress: 6.9-alpha-60093-src
• PHP: 8.2.28
• Server: nginx/1.27.5
• Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
• Browser: Chrome 137.0.0.0
• OS: Windows 10/11
• Theme: Twenty Twenty-One 2.5
• MU Plugins: None activated
• Plugins:
  • Classic Editor 1.6.7
  • Test Reports 1.2.0

Testing Instructions

1. For this, it's required Classic Editor
2. I'm using 2021 theme, have not checked with other themes, but it might be affecting all globally. I always noticed that white line was weird but never considered it a bug
3. Simply create a new Post
4. 🐞 Check for that white line at the bottom in the editor

Actual Results

1. ✅ Issue resolved with patch.

Supplemental Artifacts

Before the patch:

After the patch:

[yashjawale]

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/9043.diff

Environment

• WordPress: 6.9-alpha-60093-src
• PHP: 8.2.28
• Server: nginx/1.27.5
• Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
• Browser: Chrome 137.0.0.0
• OS: macOS
• Theme: Twenty Twenty-One 2.5
• MU Plugins: None activated
• Plugins:
  • Disable Visual Editor (custom temporary plugin for disabling visual editor for posts)
  • Test Reports 1.2.0

Actual Results

1. ✅ Issue resolved with patch.

Supplemental Artifacts

Before Patch:

After Patch:

[SirLouen]

Theoretically, this white line is meant to put the element tree position (<p>, ...)

According to @sabernhardt in todays bug scrub, this section, should be render useless under 3 conditions all the same time:

1. Screen Options -> Enable full-height editor and distraction-free functionality
2. Layout -> 1 column.
3. Clicking in Distraction free Writting mode

I've been unable to reproduce this. Personally I don't use classic editor regularly and when I entered first I saw this weird white space, and looking and this report, I thought it was simply a bug:

The weirdest part, is, with the patch, I cannot remove this section anymore. So basically I cannot reproduce what I wrote in this report anymore.

@yashjawale can you give this another try? Are you still able to reproduce this?

[SirLouen]

I think I got it

To remove this is required to enable the "Enable full-height editor and distraction-free functionality"
And have the Toolbar Toogle disabled

If this 2 conditions are met, it makes sense to disable this toolbar

After the patch

Before the patch

As we can see, before the patch doesn't make sense to have it (should be removed), because I'm inside the content box and there is no element displayed in the white bar

Back for review for the next week.

[yashjawale]

Yes I'm able to reproduce the issue too
With the patch applied, the tree is still shown when "Enable full-height editor and distraction-free functionality" & Toolbar toggle is enabled

And the bar diappears correctly when the toolbar toggle is disabled

When distraction-free functionality is disabled, the bar is shown persistently with tree data irrespective of toolbar toggle status

Ig the patch works correctly to hide the bar when its not needed

Screencasts

Before patch:
​https://files.catbox.moe/j0185k.mov

After patch:
​https://files.catbox.moe/rfteh2.mov

[SirLouen]

6.9.0 Milestone proposed during today's <bug-scrub>
​More information