Make WordPress Core

Opened 10 years ago

Last modified 3 days ago

#31599 new defect (bug)

White space between visual editor content and status bar

Reported by: iseulde's profile iseulde Owned by:
Milestone: Priority: low
Severity: normal Version: 4.1
Component: Editor Keywords: has-patch has-test-info dev-feedback
Focuses: javascript Cc:

Description

Happens when the 'path' is hidden.

Attachments (2)

Screen Shot 2015-03-11 at 18.52.09.png (23.8 KB) - added by iseulde 10 years ago.
31599.patch (1.1 KB) - added by tyxla 10 years ago.
Replace visibility:hidden with display:none to remove the white space when path is hidden.

Download all attachments as: .zip

Change History (20)

#1 @DrewAPicture
10 years ago

@iseulde: Care to make a patch for this issue?

#2 @samuelsidler
10 years ago

  • Priority changed from normal to low

This ticket was mentioned in Slack in #core by drew. View the logs.


10 years ago

#4 @DrewAPicture
10 years ago

  • Milestone changed from 4.2 to Future Release

It sounds like the solution is more complicated than a simple style change to remove the white bar. Pretty low priority, punting.

#5 @tyxla
10 years ago

Is there a reason why visibility: hidden is used here instead of display: none?

Since visibility: hidden is used, the space for the path bar is preserved even when it is hidden. This is what prevents the visual editor to expand and reach the status bar.

Why not just replace visibility: hidden with display: none? No further calculations need to be done IMHO. It seems to be working fine for me on multiple different tests. Here's a patch.

@tyxla
10 years ago

Replace visibility:hidden with display:none to remove the white space when path is hidden.

#6 @tyxla
10 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

This ticket was mentioned in PR #9043 on WordPress/wordpress-develop by @SirLouen.


3 weeks ago
#7

Everything seems to be in order.
Applying correctly. Tests coming after.

Trac ticket: https://core.trac.wordpress.org/ticket/31599

#8 @SirLouen
3 weeks ago

  • Keywords has-test-info added; needs-testing removed

Combined Bug Reproduction and Test Report

Description

✅This report validates that the indicated patch works as expected.

Patch tested: https://github.com/WordPress/wordpress-develop/pull/9043.diff

Environment

  • WordPress: 6.9-alpha-60093-src
  • PHP: 8.2.28
  • Server: nginx/1.27.5
  • Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
  • Browser: Chrome 137.0.0.0
  • OS: Windows 10/11
  • Theme: Twenty Twenty-One 2.5
  • MU Plugins: None activated
  • Plugins:
    • Classic Editor 1.6.7
    • Test Reports 1.2.0

Testing Instructions

  1. For this, it's required Classic Editor
  2. I'm using 2021 theme, have not checked with other themes, but it might be affecting all globally. I always noticed that white line was weird but never considered it a bug
  3. Simply create a new Post
  4. 🐞 Check for that white line at the bottom in the editor

Actual Results

  1. ✅ Issue resolved with patch.

Supplemental Artifacts

Before the patch:

https://i.imgur.com/dOOE9fH.png

After the patch:

https://i.imgur.com/BK3NAPH.png

This ticket was mentioned in Slack in #core-test by sirlouen. View the logs.


2 weeks ago

#10 @yashjawale
2 weeks ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://github.com/WordPress/wordpress-develop/pull/9043.diff

Environment

  • WordPress: 6.9-alpha-60093-src
  • PHP: 8.2.28
  • Server: nginx/1.27.5
  • Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
  • Browser: Chrome 137.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-One 2.5
  • MU Plugins: None activated
  • Plugins:
    • Disable Visual Editor (custom temporary plugin for disabling visual editor for posts)
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.

Supplemental Artifacts

Before Patch:
https://i.ibb.co/kg2TdH1h/Screenshot-2025-06-23-at-10-25-05-PM.png

After Patch:
https://i.ibb.co/mVKrZ5dg/Screenshot-2025-06-23-at-10-25-31-PM.png

This ticket was mentioned in Slack in #core by sirlouen. View the logs.


10 days ago

#12 @SirLouen
9 days ago

Theoretically, this white line is meant to put the element tree position (<p>, ...)

https://i.imgur.com/LWkzoQ9.png

According to @sabernhardt in todays bug scrub, this section, should be render useless under 3 conditions all the same time:

  1. Screen Options -> Enable full-height editor and distraction-free functionality
  2. Layout -> 1 column.
  3. Clicking in Distraction free Writting mode

I've been unable to reproduce this. Personally I don't use classic editor regularly and when I entered first I saw this weird white space, and looking and this report, I thought it was simply a bug:

https://i.imgur.com/DbU6ZSJ.png

The weirdest part, is, with the patch, I cannot remove this section anymore. So basically I cannot reproduce what I wrote in this report anymore.

@yashjawale can you give this another try? Are you still able to reproduce this?

This ticket was mentioned in Slack in #core by sirlouen. View the logs.


9 days ago

#14 @SirLouen
9 days ago

I think I got it

To remove this is required to enable the "Enable full-height editor and distraction-free functionality"
And have the Toolbar Toogle disabled

If this 2 conditions are met, it makes sense to disable this toolbar

After the patch

https://i.imgur.com/xj9GQmx.png

Before the patch

https://i.imgur.com/VFhSCR0.png

As we can see, before the patch doesn't make sense to have it (should be removed), because I'm inside the content box and there is no element displayed in the white bar

Back for review for the next week.

#15 @yashjawale
9 days ago

Yes I'm able to reproduce the issue too
With the patch applied, the tree is still shown when "Enable full-height editor and distraction-free functionality" & Toolbar toggle is enabled

And the bar diappears correctly when the toolbar toggle is disabled

When distraction-free functionality is disabled, the bar is shown persistently with tree data irrespective of toolbar toggle status

Ig the patch works correctly to hide the bar when its not needed

Screencasts

Before patch:
https://files.catbox.moe/j0185k.mov

After patch:
https://files.catbox.moe/rfteh2.mov

This ticket was mentioned in Slack in #core by sirlouen. View the logs.


3 days ago

#17 @SirLouen
3 days ago

  • Keywords dev-feedback added

6.9.0 Milestone proposed during today's <bug-scrub>
More information

This ticket was mentioned in Slack in #core by sirlouen. View the logs.


3 days ago

Note: See TracTickets for help on using tickets.