WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#31605 closed enhancement (maybelater)

Action Omnibus: assorted useful actions and filters

Reported by: tellyworth Owned by: DrewAPicture
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: needs-patch
Focuses: Cc:

Description

WordPress.com uses a number of hacked-in actions and simple filters for various plugins. It's likely that the actions we've added will be useful to others too, so I'm proposing in this ticket that we add them to core.

Patch forthcoming. All of these actions and filters are simple one-liners with no conditional code, so they are low risk. A few just add extra parameters to existing actions.

Attachments (1)

action-omnibus-1.diff (6.2 KB) - added by tellyworth 3 years ago.

Download all attachments as: .zip

Change History (8)

#1 @DrewAPicture
3 years ago

  • Keywords close added

Hi @tellyworth, thanks for the patch. Some notes on action-omnibus-1.diff:

  • Any new parameters added to hooks need corresponding changelog entries in the hook docs, e.g. addition @since entries for the current version mentioning that the parameter was added
  • @since versions should use the 3-digit, x.x.x style
  • Parameter descriptions should end with a period
  • Parameter types, variables, and descriptions should be vertically aligned with spaces, each section separated by a single space and wrapped at the 80-120 character mark, no tabs inside of the DocBlocks
  • There should be a blank line directly before a hook doc if the line above is equally indented
  • Hooks should be only have a corresponding DocBlock in one location, with duplicate comments pointing to the file where the original is located (even if it's in the same file), e.g. /** This filter|action is documented in path/to/file.php
  • Hook lines should follow core coding standards for spacing

All that said, realistically, these actions and filters should be submitted via individual tickets since they span several different files and components.

#2 @iseulde
3 years ago

  • Version trunk deleted

#3 @jorbin
3 years ago

While many of these have the potential to be a great addition to core, I think each one should be discussed individually.

#4 @wonderboymusic
3 years ago

  • Keywords needs-patch added; has-patch close removed
  • Milestone changed from Awaiting Review to 4.4

We can perhaps attack these one at a time here.

#5 @wonderboymusic
3 years ago

  • Owner set to DrewAPicture
  • Status changed from new to assigned

Here's some more commit juice for you - these can easily be done here and split across commits, rather than making 11 new tickets.

#6 @DrewAPicture
3 years ago

  • Milestone changed from 4.4 to Future Release

I'll take a look. Let's move this off the milestone pending ready patch(es).

#7 @DrewAPicture
2 years ago

  • Milestone Future Release deleted
  • Resolution set to maybelater
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.