WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #31616, comment 15


Ignore:
Timestamp:
03/14/2015 06:37:20 PM (7 years ago)
Author:
jipmoors
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31616, comment 15

    v1 v2  
    1212
    1313Will this pose problems?
     14
     15''What we don't want''
     16Adding additional data to the output of the filter shouldn't be an option. Thus 'tagging' that it came from a filter is out.
     17The filter request takes a lot of parameters, so re-using that filter to check if the credentials match a filter request is out aswel.
     18
     19Adding a filter inside `usable_filesystem_credentials` to allow for overriding internal checks looks to me like an unwanted and complicated way of attacking this possible problem. Mostly because the filter has been around since 2.5.0, so adding a new filter that is needed to achieve 100% coverage is not an option.