Changes between Initial Version and Version 1 of Ticket #31620, comment 9
- Timestamp:
- 07/03/2015 10:45:48 AM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #31620, comment 9
initial v1 1 1 @McGuive7 after a conversation with @toscho both of us are concerned about the use of `realpath`. 2 2 3 Our concerns regard the implications related to symlinks that may break urls because `realpath` expand them. (lines #637 and #638 in your patch)3 Our concerns regard the implications related to symlinks that may break urls because `realpath` expand them. (lines 637 and 638 in your patch) 4 4 5 5 Probably usage of `wp_normalize_path` is better because keeps the `strpos` check cross-OS compatible and avoid such problems, making this patch pretty a no-brainer.