WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #31620, comment 9


Ignore:
Timestamp:
07/03/2015 10:45:48 AM (5 years ago)
Author:
giuseppe.mazzapica
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31620, comment 9

    initial v1  
    11@McGuive7 after a conversation with @toscho both of us are concerned about the use of `realpath`.
    22
    3 Our concerns regard the implications related to symlinks that may break urls because `realpath` expand them. (lines #637 and #638 in your patch)
     3Our concerns regard the implications related to symlinks that may break urls because `realpath` expand them. (lines 637 and 638 in your patch)
    44
    55Probably usage of `wp_normalize_path` is better because keeps the `strpos` check cross-OS compatible and avoid such problems, making this patch pretty a no-brainer.