Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#31621 closed defect (bug) (fixed)

Shiny Updates: Some plugins don't give visual feedback when clicking "Update"

Reported by: ericlewis Owned by: jorbin
Priority: normal Milestone: 4.2
Component: Upgrade/Install Version: 4.2
Severity: normal Keywords: has-patch commit
Cc: Focuses: ui

Description

e.g. Jetpack

We're performing some DOM traversal of the Plugins List Table based with a plugin's slug to orient ourselves, but the <tr>'s ID we're pivoting off is actually the plugin's Name with a sanitize_title() applied to it.

Attachments (1)

31621.diff (2.9 KB ) - added by ericlewis 11 years ago.

Download all attachments as: .zip

Change History (5)

@ericlewis
11 years ago

#1 @ericlewis
11 years ago

  • Milestone Awaiting Review4.2

#2 @jorbin
11 years ago

  • Owner set to jorbin
  • Status newassigned

This ticket was mentioned in Slack in #core by drew. View the logs.


11 years ago

#4 @jorbin
11 years ago

  • Resolutionfixed
  • Status assignedclosed

In 31831:

Ensure that we target the correct plugin row for update updates

The DOM traversal of the plugins list table was less than ideal. By switching to data attributes, we can better target the DOM elements we want to update.

Props ericlewis
Fixes #31621

Note: See TracTickets for help on using tickets.