WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#31639 closed defect (bug) (fixed)

Press This: Ignore auto-generated description

Reported by: kraftbj Owned by: azaozz
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Press This Keywords: needs-patch
Focuses: Cc:
PR Number:

Description (last modified by DrewAPicture)

When text is not selected on the parent window and the bookmarklet is used or in any case with the direct entry URL, Press This attempts to grab a description (Twitter, Facebook, or meta) for insertion.

We should be smart about this and stop this in certain cases, such as when an ellipsis is used in the description, since that usually means it's been auto-generated.

Attachments (1)

31639.diff (484 bytes) - added by kraftbj 5 years ago.
Example of removing descriptions ending with …

Download all attachments as: .zip

Change History (3)

@kraftbj
5 years ago

Example of removing descriptions ending with ...

#1 @DrewAPicture
5 years ago

  • Description modified (diff)
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.2
  • Type changed from enhancement to defect (bug)

#2 @azaozz
5 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 31810:

Press This: ignore site descriptions that end with an ellipsis. These are most likely auto-generated.
Props kraftbj. Fixes #31639.

Note: See TracTickets for help on using tickets.