WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #31652, comment 12


Ignore:
Timestamp:
10/05/2016 02:45:08 PM (4 years ago)
Author:
adamsilverstein
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31652, comment 12

    initial v1  
    33I was able to reproduce this bug locally using the chrome debugger device mode to emulate a touch device.
    44
    5 I tracked this bug back to this commit: https://core.trac.wordpress.org/changeset/29446 which was part of an extensive effort to make the mida modal more usable on small screen devices in https://core.trac.wordpress.org/ticket/27423. In this commit an explicit check for `wp.media.isTouchDevice` was added that bypasses sortability for touch devices. I believe this was added because sortable interfered with selection which no longer seems to be the case in my testing.
     5I tracked this bug back to this commit: https://core.trac.wordpress.org/changeset/29446 which was part of an extensive effort to make the media modal more usable on small screen devices in https://core.trac.wordpress.org/ticket/27423. In this commit an explicit check for `wp.media.isTouchDevice` was added that bypasses sortability for touch devices. I believe this was added because sortable interfered with selection which no longer seems to be the case in my testing.
    66
    77@celloexpressions @cgrymala @webbistro @dan.rossiter can you please test my patch with your touch enabled devices to see if this resolves the issue you reported and also check to see if you notice any inadvertent side effects from the change.