Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#31657 closed defect (bug) (fixed)

Press This: Firefox redirects parent page to a return value of true when pressing

Reported by: DrewAPicture Owned by: azaozz
Priority: normal Milestone: 4.2
Component: Press This Version: 4.2
Severity: major Keywords: has-patch
Cc: Focuses: javascript

Description

Looks like Firefox is back to its old tricks redirecting the parent page and displaying a true return when pressing links. This is regular Firefox.

Attachments (1)

31657.diff​ (671 bytes ) - added by stephdau 12 years ago.

Download all attachments as: .zip

Change History (6)

#1 @DrewAPicture
12 years ago

  • Summary Press This: Redirects parent page to a return value of true when pressing → Press This: Firefox redirects parent page to a return value of true when pressing

@stephdau
12 years ago

#2 @stephdau
12 years ago

The grunt task to uglify the bookmarklet is a special one, and uses negate_iife: false to cope with Firefox.

Because of this, we ignore wp-admin/js/bookmarklet.js in the core uglification task.
But that means that this task still finds the committed wp-admin/js/bookmarklet.min.js and (re-)uglifies it, but without negate_iife: false, therefore leading to having the issue with Firefox, specifically with the build branch (and releases), vs the bookmarklet working fine with the src branch.

Attached patch fixes that issue by wildcarding wp-admin/js/bookmarklet.*, hence ignoring both the un-uglified and pre-uglified versions.

#3 @azaozz
12 years ago

  • Owner set to azaozz
  • Resolution → fixed
  • Status new → closed

In 31796:

Press This: exclude both bookmarklet.js and bookmarklet.min.js from the main uglify task. Props stephdau. Fixes #31657.

#4 @DrewAPicture
12 years ago

  • Keywords has-patch added; needs-patch removed

#5 @azaozz
12 years ago

In 31800:

Press This: bump bookmarklet's version. See #31657.

Note: See TracTickets for help on using tickets.