#31657 closed defect (bug) (fixed)
Press This: Firefox redirects parent page to a return value of true when pressing
Reported by: | DrewAPicture | Owned by: | azaozz |
---|---|---|---|
Milestone: | 4.2 | Priority: | normal |
Severity: | major | Version: | 4.2 |
Component: | Press This | Keywords: | has-patch |
Focuses: | javascript | Cc: |
Description
Looks like Firefox is back to its old tricks redirecting the parent page and displaying a true
return when pressing links. This is regular Firefox.
Attachments (1)
Change History (6)
#1
@
10 years ago
- Summary changed from Press This: Redirects parent page to a return value of true when pressing to Press This: Firefox redirects parent page to a return value of true when pressing
Note: See
TracTickets for help on using
tickets.
The grunt task to uglify the bookmarklet is a special one, and uses
negate_iife: false
to cope with Firefox.Because of this, we ignore
wp-admin/js/bookmarklet.js
in thecore
uglification task.But that means that this task still finds the committed
wp-admin/js/bookmarklet.min.js
and (re-)uglifies it, but withoutnegate_iife: false
, therefore leading to having the issue with Firefox, specifically with thebuild
branch (and releases), vs the bookmarklet working fine with thesrc
branch.Attached patch fixes that issue by wildcarding
wp-admin/js/bookmarklet.*
, hence ignoring both the un-uglified and pre-uglified versions.