#31657 closed defect (bug) (fixed)
Press This: Firefox redirects parent page to a return value of true when pressing
| Reported by: | DrewAPicture | Owned by: | azaozz |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.2 |
| Component: | Press This | Version: | 4.2 |
| Severity: | major | Keywords: | has-patch |
| Cc: | Focuses: | javascript |
Description
Looks like Firefox is back to its old tricks redirecting the parent page and displaying a true return when pressing links. This is regular Firefox.
Attachments (1)
Change History (6)
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
The grunt task to uglify the bookmarklet is a special one, and uses
negate_iife: falseto cope with Firefox.Because of this, we ignore
wp-admin/js/bookmarklet.jsin thecoreuglification task.But that means that this task still finds the committed
wp-admin/js/bookmarklet.min.jsand (re-)uglifies it, but withoutnegate_iife: false, therefore leading to having the issue with Firefox, specifically with thebuildbranch (and releases), vs the bookmarklet working fine with thesrcbranch.Attached patch fixes that issue by wildcarding
wp-admin/js/bookmarklet.*, hence ignoring both the un-uglified and pre-uglified versions.