WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #31661, comment 12


Ignore:
Timestamp:
03/27/2015 02:20:53 AM (6 years ago)
Author:
Cheffheid
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31661, comment 12

    initial v1  
    55Might not need the `document.getSelection()` check, I'm not too sure.
    66
    7 Anyhow, with this patch it seems that all modern browsers will now set `keyboardSelectionIE` (because they all support `window.getSelection()`, so that makes sense) and so I'm not sure if the additional else clause on lines 537 - 540 are even needed anymore either.
     7Anyhow, with this patch it seems that other modern browsers will now set `keyboardSelectionIE` (because they all support `window.getSelection()`, so that makes sense) and so I'm not sure if the additional else clause on lines 537 - 540 are even needed anymore either.
    88
    99I did a quick test with mouse and keyboard in IE 11, Firefox 36, and Chrome 41 on Windows and all seems to be functioning as expected. Would appreciate some help testing and help/direction cleaning/reviewing the code. :)