media.view.Settings.Gallery.extend doesn't work anymore

[bduclos]

I use the code below to add custom parameters to galleries. (Jetpack do the same to add a type parameter). Since Trunk split the javascript files into modules, it doesn't work anymore.

media.view.Settings.Gallery = media.view.Settings.Gallery.extend({})

[DrewAPicture]

See also comment:34:ticket:28510.

@wonderboymusic: Could I get you to follow up here please? Looks like there are a couple of reports of issues following the JS modularization in #28510.

[wonderboymusic]

Oh man - I will take a hard look and see what is necessary here

[wonderboymusic]

In 31935:

Let us pray to the gods of backwards compatibility:

• The way that the JS modules for media are currently set up turns the existing global wp.media namespace into a read-only API, this is bad.
• For the existing module implementation to work with plugins, those looking to override or extend a class would have to modify their own plugin to use browserify - we can't expect this to happen
• Because the general way that plugins override media classes is via machete (resetting them to something else), we cannot use require( 'module' ) in the internal code for media modules

We CAN continue to use require( 'fun/js' ) in the manifests for media.

Future code/projects should carefully consider what is made to be public API. In 3.5, EVERYTHING was made public, so everything shall remain public.

See #31684, #28510.

[wonderboymusic]

Let me know if other problems arise, please.