Context Navigation

← Previous Ticket
Next Ticket →

#31684 closed defect (bug) (fixed)

media.view.Settings.Gallery.extend doesn't work anymore

Reported by:	bduclos	Owned by:	wonderboymusic
Priority:	normal	Milestone:	4.2
Component:	Media	Version:	4.2
Severity:	normal	Keywords:
Cc:		Focuses:	javascript

Description

I use the code below to add custom parameters to galleries. (Jetpack do the same to add a type parameter). Since Trunk split the javascript files into modules, it doesn't work anymore.

media.view.Settings.Gallery = media.view.Settings.Gallery.extend({})

Attachments (1)

31684.diff (146.4 KB ) - added by wonderboymusic 11 years ago.

Download all attachments as: .zip

Change History (8)

This ticket was mentioned in Slack in #core by drew. View the logs.

11 years ago

#3 @DrewAPicture
11 years ago

Keywords dev-feedback added
Milestone Awaiting Review → 4.2
Owner set to wonderboymusic
Priority normal → high
Status new → assigned

#4 @wonderboymusic
11 years ago

Oh man - I will take a hard look and see what is necessary here

@wonderboymusic
11 years ago

Attachment 31684.diff added

#5 @wonderboymusic
11 years ago

In 31935:

Let us pray to the gods of backwards compatibility:

The way that the JS modules for media are currently set up turns the existing global wp.media namespace into a read-only API, this is bad.
For the existing module implementation to work with plugins, those looking to override or extend a class would have to modify their own plugin to use browserify - we can't expect this to happen
Because the general way that plugins override media classes is via machete (resetting them to something else), we cannot use require( 'module' ) in the internal code for media modules

We CAN continue to use require( 'fun/js' ) in the manifests for media.

Future code/projects should carefully consider what is made to be public API. In 3.5, EVERYTHING was made public, so everything shall remain public.

See #31684, #28510.

#6 @wonderboymusic
11 years ago

Keywords dev-feedback removed
Resolution → fixed
Status assigned → closed

Let me know if other problems arise, please.

#7 @DrewAPicture
11 years ago

Priority high → normal

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#31684 closed defect (bug) (fixed)

media.view.Settings.Gallery.extend doesn't work anymore

Description

Attachments (1)

Change History (8)

This ticket was mentioned in ​Slack in #core by drew. ​View the logs. 11 years ago

This ticket was mentioned in ​Slack in #core by drew. ​View the logs. 11 years ago

#3 @DrewAPicture 11 years ago

#4 @wonderboymusic 11 years ago

@wonderboymusic 11 years ago

#5 @wonderboymusic 11 years ago

#6 @wonderboymusic 11 years ago

#7 @DrewAPicture 11 years ago

Download in other formats:

This ticket was mentioned in Slack in #core by drew. View the logs.

11 years ago

This ticket was mentioned in Slack in #core by drew. View the logs.

11 years ago

#3 @DrewAPicture
11 years ago

#4 @wonderboymusic
11 years ago

@wonderboymusic
11 years ago

#5 @wonderboymusic
11 years ago

#6 @wonderboymusic
11 years ago

#7 @DrewAPicture
11 years ago