WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 7 months ago

#31694 closed defect (bug) (fixed)

Notice warning in class-wp-plugins-list-table.php since revision 31831

Reported by: imath Owned by: jorbin
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Plugins Keywords:
Focuses: administration Cc:
PR Number:

Description

Hi,

Just noticed this warning today :
Notice: Undefined index: slug in /pathto/develop.git.wordpress.org/src/wp-admin/includes/class-wp-plugins-list-table.php on line 521

I'm not sure if there is a new tag to add in the plugin's header. The problem occurs with one of my plugin that is not hosted on WordPress.org, so my guess is that the slug is the one of the plugin's WordPress.org repo.

I'd suggest to eventually do a check and use a generic fallback or a null value to avoid the notice. See attached patch.

Have a nice day :)

Attachments (1)

31694.patch (793 bytes) - added by imath 5 years ago.

Download all attachments as: .zip

Change History (7)

@imath
5 years ago

#1 @SergeyBiryukov
5 years ago

  • Component changed from Administration to Plugins

This ticket was mentioned in Slack in #core by afercia. View the logs.


5 years ago

#3 @jorbin
5 years ago

  • Milestone changed from Awaiting Review to 4.2

#4 @jorbin
5 years ago

  • Owner set to jorbin
  • Status changed from new to assigned

#5 @jorbin
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 31834:

Fix notice that exists for plugins with no slug

Not all plugins have a slug, especially plugins not from the WordPress.org repository.

Props imath for initial patch.
Fixes #31694

Note: See TracTickets for help on using tickets.