WordPress.org

Make WordPress Core

Opened 15 years ago

Closed 14 years ago

#3171 closed enhancement (fixed)

Don't hide advanced button

Reported by: mypatricks Owned by: rob1n
Milestone: 2.3 Priority: normal
Severity: normal Version: 2.2
Component: TinyMCE Keywords:
Focuses: Cc:

Description

The advanced button(wpAdv) should be appear for click.

$mce_buttons = apply_filters('mce_buttons', array('bold', 'italic', 'underline', 'strikethrough', 'separator', 'bullist', 'numlist', 'outdent', 'indent', 'separator', 'justifyleft', 'justifycenter', 'justifyright', 'separator', 'link', 'unlink', 'image', 'wp_more', 'separator', 'spellchecker', 'separator', 'wp_help', 'wp_adv', 'wp_adv_start', 'formatselect', 'justifyfull', 'forecolor', 'separator', 'pastetext', 'pasteword', 'separator', 'removeformat', 'cleanup', 'separator', 'charmap', 'separator', 'undo', 'redo', 'wp_adv_end'));

Attachments (2)

advanced-button.gif (3.2 KB) - added by mypatricks 15 years ago.
3171.diff (1.5 KB) - added by johnbillion 15 years ago.
Show Advanced Toolbar button on RTE toolbar

Download all attachments as: .zip

Change History (18)

#1 @foolswisdom
15 years ago

  • Milestone 2.0.5 deleted

Hi mypatricks,

Would you write your bugs starting by describing the problem; who the problem impacts, etc. I know it is a little more work, but it increases the change of your work being checked in and it allows more collaboration -- a person does not have to be a hacker to verifiy that a bug is really fixed, or try and find edge cases with a fix.

If you have a fix, please attach it as a patch.

What is the advanced button(wpAdv)? What is the attached gif showing?

#2 @mypatricks
15 years ago

  • Milestone set to 2.0.5

This advanced button was ready in tinymce editor. Press alt+B you will see it(Wordpress). It's show more edit button on your editor.

#3 @foolswisdom
15 years ago

  • Milestone 2.0.5 deleted
  • Resolution set to invalid
  • Status changed from new to closed

Marking INVALID, no evidence provided that supports that this improves the user experience.

alt+B does Bold for me in 2.0.4 .

#4 @mypatricks
15 years ago

  • Milestone set to 2.0.5

The accesskey has been change alt V, please see here
http://trac.wordpress.org/browser/trunk/wp-includes/js/tinymce/plugins/wordpress/editor_plugin.js

in line 42/43

#5 @foolswisdom
15 years ago

  • Keywords rte added; editor removed
  • Milestone 2.0.5 deleted

Hi mypatricks,

Thank you for the update. For me in Firefox that opens the menu bar item View, though what key combination it is, is secondary to the questions I wrote in my initial comment.

Please do not update the Milestone. "This is usually an option that Wordpress developers will alter and decide on, unless the bug is severe." http://codex.wordpress.org/Submitting_Bugs

#6 @johnbillion
15 years ago

Fools, the access key for the advanced toolbar is now Alt+Shift+V in Firefox. The extra toolbar buttons are handy for power users but I'm not so sure it's necessary to have the advanced button showing. It could cause confusion if it's accidentally (or purposefully) clicked and this new line of toolbar buttons suddenly shows up.

Semi-related: #2052 and #4172

#7 @JeremyVisser
15 years ago

  • Component changed from Administration to TinyMCE
  • Keywords rte removed
  • Version changed from 2.0.4 to 2.2

I don't think it's confusing at all. Compare to the Favorites and History buttons in IE6 popping up a pane on the left.

I think unhiding the button would make the editor much more useful to many people who would otherwise be unaware of this feature.

#8 @foolswisdom
15 years ago

  • Milestone set to 2.4

#9 @foolswisdom
15 years ago

  • Milestone 2.4 deleted

#10 @Otto42
15 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

+1

Adding the advanced button to the bar gives some very handy options in 2.1.3, including the "paste from text" and "paste from Word" buttons that would eliminate a whole lot of problematic usage. It also adds semantic pulldowns that people can use to make headings, paragraphs, etc. Not displaying that secondary bar by default is a good thing, admittedly, but relying on a keypress that's unusual (alt-shift-v in firefox) and not cross-browser (it's just alt-v in some versions of IE) is annoying.

It's well worth the minor amount of toolbar space to have a button for a second dropdown bar. Even if it does cause user confusion, which I don't think will occur, as people are used to multiple toolbars (thanks to Word).

The specific change required is to wp-includes/js/tiny_mce_config.php. The line that defines $mce_buttons is an array of strings.

The string 'wp_adv_start' defines the split point between the normal toolbar and the advanced hidden toolbar. The string 'wp_adv' is the button to hide/unhide that bar. So having 'wp_adv' after 'wp_adv_start' makes little sense anyway, as this puts that button on the hidden toolbar, where it can never actually be clicked.

So, proposed change:
-Move 'wp_adv' directly before 'wp_adv_start'.
-Eliminate 'separator' after 'wp_adv' and 'wp_adv_start' for looks only.

This works very well in 2.1.3. Have not tested with 2.2.

#11 @foolswisdom
15 years ago

  • Milestone set to 2.3

#12 follow-up: @andy
15 years ago

I wouldn't mind making the button visible. I originally made it as a sort of easter egg but if popularity demands it, go ahead and make it visible. Plenty of people would be happily surprised to know that the editor has more than one row of buttons.

@johnbillion
15 years ago

Show Advanced Toolbar button on RTE toolbar

#13 in reply to: ↑ 12 @johnbillion
15 years ago

+1

JermeyVisser, Otto42 and andy have made good points about the Advanced Toolbar button. Preliminary patch attached to display the Advanced Toolbar button.

#14 @rob1n
14 years ago

  • Owner changed from ryan to rob1n
  • Status changed from reopened to new

+1.

#15 @rob1n
14 years ago

  • Status changed from new to assigned

#16 @rob1n
14 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [5429]) Show WP-Adv TinyMCE button by default. Props johnbillion. fixes #3171

Note: See TracTickets for help on using tickets.