WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#31710 closed defect (bug) (fixed)

Firefox uses WP emoji for smileys but the native for frowneys

Reported by: saracannon Owned by: iseulde
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.2
Component: Formatting Keywords:
Focuses: Cc:

Description

When "Convert emoticons like :-) and :-P to graphics on display" is checked, firefox converts the smilely but uses the native for the frowneys

Attachments (3)

emoji-firefox.jpg (94.5 KB) - added by saracannon 5 years ago.
31710.diff (1.1 KB) - added by saracannon 5 years ago.
emoji fix smileys
ff.jpg (21.6 KB) - added by saracannon 5 years ago.
with patch

Download all attachments as: .zip

Change History (21)

This ticket was mentioned in Slack in #core by iseulde. View the logs.


5 years ago

@saracannon
5 years ago

emoji fix smileys

#2 @saracannon
5 years ago

same fix for #31709

@saracannon
5 years ago

with patch

#3 @saracannon
5 years ago

in firefox after the patch is applied, the emoji's aren't lined completely up but that is a FF issue not a WP issue.

#4 follow-ups: @nacin
4 years ago

So, yeah, this is because there's no good translation for :) into emoji — specifically, a smile with a closed mouth.

This is also why Slack calls this particular :) a :simple_smile: — it's their own invention.

I don't think we can or should do anything here. If you use actual emoji characters, you won't even have the opportunity to insert the :) smiley.

#5 @DrewAPicture
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
  • Version trunk deleted

#6 in reply to: ↑ 4 @iseulde
4 years ago

  • Milestone set to Awaiting Review
  • Resolution wontfix deleted
  • Status changed from closed to reopened
  • Version set to trunk

Replying to nacin:

So, yeah, this is because there's no good translation for :) into emoji — specifically, a smile with a closed mouth.

In 4.1 the smiley has an open mouth, but I agree this is not ideal. I see a few applications converting them to

#7 in reply to: ↑ 4 @iseulde
4 years ago

Great, Trac just cut off my comment on the first emoji.

#8 @iseulde
4 years ago

Replying to nacin:

So, yeah, this is because there's no good translation for :) into emoji — specifically, a smile with a closed mouth.

In 4.1 the smiley has an open mouth, but I agree this is not ideal. I see a few applications converting them to 1F60A: Smiling Face with Smiling Eyes (e.g. FB Messenger), or the emoji variant of ☺ (263A: White Smiling Face). The last one is what we should use if OS X and Twemoji didn't decide to make the smiley so blushy... That does not look like a good representation of the emoji variant of Smiling Face.

So there is a smile with a closed mouth. And that's probably what the unicode consortium will tell you?

Also, for the frowneys we currently use 1F626: Frowning Face with Open Mouth, which has an open mouth by definition, so that's not right either. Shouldn't we be using the emoji variant of ☹ (2639: White Frowning Face)? Unfortunately Twemoji does not replace the emoji variant (not sure why, because it does replace the "White Smiling Face" variant).

Reopening because I think this needs some more investigation.

Note: I only added the text variants because Trac removes them.

Last edited 4 years ago by iseulde (previous) (diff)

#10 @iseulde
4 years ago

So there is no standardised emoji style variant of White Frowning Face, which is why Twemoji does not replace it, but there is for White Smiling Face (263A FE0F), which, according to them, should look like this: http://www.unicode.org/cgi-bin/varglyph?24-263A-FE0F.

#11 @iseulde
4 years ago

Filed an issue for Twemoji: https://github.com/twitter/twemoji/issues/58.

Additionally there is SLIGHTLY FROWNING FACE and SLIGHTLY SMILING FACE, which we could use for this too. See http://unicode.org/charts/PDF/U1F600.pdf. Unfortunately Twemoji does not convert those either.

#12 @iseulde
4 years ago

1F641 and 1F642 respectively.

#13 @helen
4 years ago

So what's going on here? Do we need to make any changes for 4.2, for the future, or just waiting on Twemoji?

#14 follow-up: @pento
4 years ago

We're waiting for Twemoji. All of the files are hosted on WordPress.org, so won't be a problem to update after 4.2 is released.

#15 @helen
4 years ago

  • Milestone changed from Awaiting Review to WordPress.org

#16 in reply to: ↑ 14 @iseulde
4 years ago

  • Milestone changed from WordPress.org to Awaiting Review

Replying to pento:

We're waiting for Twemoji. All of the files are hosted on WordPress.org, so won't be a problem to update after 4.2 is released.

We would still need to update $wpsmiliestrans?

#17 @iseulde
4 years ago

  • Owner set to iseulde
  • Resolution set to fixed
  • Status changed from reopened to closed

In 36336:

Emoji: adjust $wpsmiliestrans

Swap simple-smile.png with SLIGHTLY SMILING FACE
and frownie.png with SLIGHTLY FROWNING FACE

Fixes #31710.

#18 @iseulde
4 years ago

  • Milestone changed from Awaiting Review to 4.5
Note: See TracTickets for help on using tickets.