WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#31712 closed defect (bug) (fixed)

Login screens links lack focus style

Reported by: afercia Owned by: afercia
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.1
Component: Login and Registration Keywords: has-patch commit
Focuses: ui, accessibility Cc:

Description

Log in, Register and Lost your password screens have links that lack the standard WordPress focus style.
Also, please notice the color contrast ratio is not sufficient for AA level but this belongs in a separate ticket and we're also waiting for #31234 to be in core.
See also related #31548.

Attachments (1)

31712.patch (726 bytes) - added by afercia 7 years ago.
Add standard focus style in login.css

Download all attachments as: .zip

Change History (11)

@afercia
7 years ago

Add standard focus style in login.css

#1 @afercia
7 years ago

  • Keywords has-patch added

#2 @afercia
6 years ago

  • Milestone changed from Awaiting Review to 4.3
  • Owner set to afercia
  • Status changed from new to assigned

#3 @afercia
6 years ago

  • Keywords commit added

This patch does only one, simple, small, thing: adds focus style for the login screens links (including the /?action=register and /?action=lostpassword screens). I'd recommend for commit consideration. See screenshot:

https://cldup.com/cDeu5jS0gC.png

#4 @obenland
6 years ago

In FF and Safari I'm not even able to reach those links by tabbing, is that a known issue?

#5 @joedolson
6 years ago

Are you on a Mac? Do you have the Safari settings configured to allow tab to focus on links as well as inputs?

#6 @obenland
6 years ago

Ah, yes, that fixed in in Safari.

#7 @joedolson
6 years ago

It's a Mac issue relating to default settings, not something that WordPress has to deal with.

#8 @afercia
6 years ago

Also, for Firefox:
https://bugzilla-dev.allizom.org/show_bug.cgi?id=1034338

...the fact that we honor that setting is a point of confusion for many web developrs and users, especially when they know about the separate setting in Safari

I think Firefox has just accessibility.tabfocus in about:config to expose that setting

#9 @markjaquith
6 years ago

Does what it says, should be a good change for accessibility!

#10 @obenland
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 32682:

Use WordPress' default focus styles for links on login screens.

Props afercia.
Fixes #31712.

Note: See TracTickets for help on using tickets.