WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#31714 closed defect (bug) (fixed)

Missing ID's in the post table Quick Edit touch_time

Reported by: rianrietveld Owned by: rianrietveld
Milestone: 4.3 Priority: high
Severity: normal Version: 0.71
Component: Administration Keywords: has-patch commit
Focuses: accessibility Cc:

Description

The ID's are missing in the input fields for the post date and time in the quick edit form in post table. This patch adds them.

Attachments (4)

31714.patch (3.0 KB) - added by rianrietveld 6 years ago.
Adds id's to the date/time input fields
31714.2.patch (6.5 KB) - added by rianrietveld 6 years ago.
31714.3.patch (5.9 KB) - added by rianrietveld 6 years ago.
Refresh of 31714.2
31714.4.patch (6.7 KB) - added by afercia 6 years ago.

Download all attachments as: .zip

Change History (15)

@rianrietveld
6 years ago

Adds id's to the date/time input fields

This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.


6 years ago

#2 @joedolson
6 years ago

  • Priority changed from normal to high

#3 @DrewAPicture
6 years ago

  • Keywords has-patch added
  • Version changed from trunk to 0.71

#4 follow-up: @afercia
6 years ago

Hi Rian, double checked and I'm not sure it can be done this way. The Quick Edit (and Bulk Edit) form is initially hidden at the bottom of the page, then cloned and populated with specific Post data via JavaScript. The current patch will use always the same IDs and since the Quick Edit form gets cloned, its copy will use the same IDs so we will have duplicated IDs. We could try to use implicitly associated labels (labels that wrap the input) and get rid of the the IDs altogether.

Also, we should use a fieldset and the previous label "Date" should be the fieldset legend.
Working on a patch but I'd like to hear the accessibility team opinion.

For some background, see r28730

Last edited 6 years ago by afercia (previous) (diff)

#5 in reply to: ↑ 4 @afercia
6 years ago

Replying to afercia:

and get rid of the the IDs altogether.

the IDs are needed for JS, I meant get rid of the for attributes and just have labels wrapping the input fields

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


6 years ago

#7 @rianrietveld
6 years ago

  • Milestone changed from Awaiting Review to 4.3
  • Owner set to rianrietveld
  • Status changed from new to accepted

#8 @rianrietveld
6 years ago

New patch 31714.2.patch: added a fieldset and legend for Date and put the different input fields inside related labels.
Added some CSS lines to match original layout

@rianrietveld
6 years ago

Refresh of 31714.2

This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.


6 years ago

@afercia
6 years ago

#10 @afercia
6 years ago

  • Keywords commit added

Refreshed patch after r32796. Also tries to save some <div>s. Tweaked the CSS part to be sure there are no visual changes. Tested in Firefox+NVDA all legends/grouping and labels get read out nicely.

#11 @wonderboymusic
6 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 32945:

After [32796], improve the accessibility and markup for instances of touch_time().

Props rianrietveld, afercia.
Fixes #31714.

Note: See TracTickets for help on using tickets.