Opened 10 years ago
Closed 10 years ago
#31714 closed defect (bug) (fixed)
Missing ID's in the post table Quick Edit touch_time
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.3 | Priority: | high |
Severity: | normal | Version: | 0.71 |
Component: | Administration | Keywords: | has-patch commit |
Focuses: | accessibility | Cc: |
Description
The ID's are missing in the input fields for the post date and time in the quick edit form in post table. This patch adds them.
Attachments (4)
Change History (15)
This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.
10 years ago
#4
follow-up:
↓ 5
@
10 years ago
Hi Rian, double checked and I'm not sure it can be done this way. The Quick Edit (and Bulk Edit) form is initially hidden at the bottom of the page, then cloned and populated with specific Post data via JavaScript. The current patch will use always the same IDs and since the Quick Edit form gets cloned, its copy will use the same IDs so we will have duplicated IDs. We could try to use implicitly associated labels (labels that wrap the input) and get rid of the the IDs altogether.
Also, we should use a fieldset
and the previous label "Date" should be the fieldset legend
.
Working on a patch but I'd like to hear the accessibility team opinion.
For some background, see r28730
#5
in reply to:
↑ 4
@
10 years ago
Replying to afercia:
and get rid of the the IDs altogether.
the IDs are needed for JS, I meant get rid of the for
attributes and just have labels wrapping the input fields
This ticket was mentioned in Slack in #accessibility by afercia. View the logs.
10 years ago
#7
@
10 years ago
- Milestone changed from Awaiting Review to 4.3
- Owner set to rianrietveld
- Status changed from new to accepted
#8
@
10 years ago
New patch 31714.2.patch: added a fieldset and legend for Date and put the different input fields inside related labels.
Added some CSS lines to match original layout
Adds id's to the date/time input fields