Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#31730 closed defect (bug) (fixed)

One more space to merge strings

Reported by: pavelevap's profile pavelevap Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.3 Priority: normal
Severity: normal Version: 2.9
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

See attached patch.

Attachments (1)

31730.patch (1.1 KB) - added by pavelevap 9 years ago.

Download all attachments as: .zip

Change History (7)

@pavelevap
9 years ago

#1 follow-up: @DrewAPicture
9 years ago

  • Keywords has-patch added

We should probably change the other instance of the string to remove the extra space as \n drives the second half of the string to a new line.

With extra space:
http://f.cl.ly/items/0c38463X2A2l1n2H2u0S/Screen%20Shot%202015-03-22%20at%2011.35.19%20AM.png

Without the extra space:
http://f.cl.ly/items/3m2J1m260g2d3c1a3q3M/Screen%20Shot%202015-03-22%20at%2011.34.24%20AM.png

#2 in reply to: ↑ 1 @pavelevap
9 years ago

Replying to DrewAPicture:

We should probably change the other instance of the string to remove the extra space as \n drives the second half of the string to a new line.

Yes, but then we should also change many other strings which all have two spaces (and same text "Cancel to stop, OK to delete). Main purpose of this ticket was only merging two same strings (and use 2 spaces to follow example of all other strings). But I am fine to create patch for all other strings and change them to use only one space.

#3 @DrewAPicture
9 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Version changed from trunk to 2.9

#4 @pavelevap
9 years ago

Is there anything I can do to make it happen?

#5 @SergeyBiryukov
9 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 33433:

Merge two duplicate strings.

props pavelevap.
fixes #31730.

#6 @SergeyBiryukov
9 years ago

  • Milestone changed from Future Release to 4.3
Note: See TracTickets for help on using tickets.