WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#31735 closed defect (bug) (fixed)

Emoji: Use `set_url_scheme` for CDN's URL

Reported by: extendwings Owned by: pento
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Emoji Keywords: emoji
Focuses: performance Cc:
PR Number:

Description

Currently, wp_staticize_emoji() forces all sites to use HTTPS for CDN (even if they are using HTTP!)
I think CDN's URL scheme should be relative.

With this fix, HTTP-user may access the site faster!

Attachments (1)

WordPress_master...shield-9_emoji_cdn_scheme.diff.txt (1.1 KB) - added by extendwings 5 years ago.

Download all attachments as: .zip

Change History (6)

#1 @extendwings
5 years ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #core by pento. View the logs.


5 years ago

#3 @pento
5 years ago

  • Owner set to pento
  • Resolution set to fixed
  • Status changed from new to closed

In 31861:

Emoji: Set the emoji image protocol with set_url_scheme(), instead of defaulting to HTTPS.

Props extendwings.

Fixes #31735.

#4 @pento
5 years ago

  • Keywords emoji added; has-patch removed
  • Milestone changed from Awaiting Review to 4.2
  • Type changed from enhancement to defect (bug)

#5 @pento
4 years ago

  • Component changed from Formatting to Emoji
Note: See TracTickets for help on using tickets.