Context Navigation

← Previous Ticket
Next Ticket →

#31738 closed defect (bug) (fixed)

Shiny Updates - JS Error

Reported by:	pavelevap	Owned by:	jorbin
Priority:	normal	Milestone:	4.2
Component:	Upgrade/Install	Version:	4.2
Severity:	normal	Keywords:
Cc:		Focuses:

Description

Go to Plugins - everything works as expected.

Go to Plugins - Updates Available (tab) - clicking on "update now" - nothing happens with following JS error:

Uncaught TypeError: Cannot read property 'replace' of undefined in updates.js?ver=4.2-beta2-31866-src:195

But plugin is updated in the end...

There is also PHP notice:

Undefined index: plugin in wp-admin/includes/update.php:279

Change History (7)

#1 @SergeyBiryukov
11 years ago

Milestone Awaiting Review → 4.2

#2 @samuelsidler
11 years ago

Priority normal → high

#3 @jorbin
11 years ago

Owner set to jorbin
Status new → assigned

Thanks pavelevap. I'm looking into this right now.

This ticket was mentioned in Slack in #core by jorbin. View the logs.

11 years ago

#5 @jorbin
11 years ago

Resolution → fixed
Status assigned → closed

In 31872:

Fill $plugins['upgrade'] with extra info for use in list table

Shiny updates depends upon information from the update_plugins site transient in order to set data- attributes which are used by JavaScript. Since /wp-admin/plugins.php?plugin_status=upgrade uses $plugin['upgrade'] rather than $plugins['all'], we need to fill that information in both places.

Fixes #31738.

#6 @SergeyBiryukov
11 years ago

In 31873:

Fix a typo in [31872].

see #31738.

#7 @DrewAPicture
11 years ago

Priority high → normal

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#31738 closed defect (bug) (fixed)

Shiny Updates - JS Error

Description

Change History (7)

#1 @SergeyBiryukov 11 years ago

#2 @samuelsidler 11 years ago

#3 @jorbin 11 years ago

This ticket was mentioned in ​Slack in #core by jorbin. ​View the logs. 11 years ago

#5 @jorbin 11 years ago

#6 @SergeyBiryukov 11 years ago

#7 @DrewAPicture 11 years ago