WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#31738 closed defect (bug) (fixed)

Shiny Updates - JS Error

Reported by: pavelevap Owned by: jorbin
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Upgrade/Install Keywords:
Focuses: Cc:

Description

Go to Plugins - everything works as expected.

Go to Plugins - Updates Available (tab) - clicking on "update now" - nothing happens with following JS error:

Uncaught TypeError: Cannot read property 'replace' of undefined in updates.js?ver=4.2-beta2-31866-src:195

But plugin is updated in the end...

There is also PHP notice:

Undefined index: plugin in wp-admin/includes/update.php:279

Change History (7)

#1 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 4.2

#2 @samuelsidler
6 years ago

  • Priority changed from normal to high

#3 @jorbin
6 years ago

  • Owner set to jorbin
  • Status changed from new to assigned

Thanks pavelevap. I'm looking into this right now.

This ticket was mentioned in Slack in #core by jorbin. View the logs.


6 years ago

#5 @jorbin
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 31872:

Fill $plugins['upgrade'] with extra info for use in list table

Shiny updates depends upon information from the update_plugins site transient in order to set data- attributes which are used by JavaScript. Since /wp-admin/plugins.php?plugin_status=upgrade uses $plugin['upgrade'] rather than $plugins['all'], we need to fill that information in both places.

Fixes #31738.

#6 @SergeyBiryukov
6 years ago

In 31873:

Fix a typo in [31872].

see #31738.

#7 @DrewAPicture
6 years ago

  • Priority changed from high to normal
Note: See TracTickets for help on using tickets.