Opened 10 years ago
Closed 10 years ago
#31739 closed defect (bug) (fixed)
Shiny Updates - support for details modal window
Reported by: | pavelevap | Owned by: | jorbin |
---|---|---|---|
Milestone: | 4.2 | Priority: | normal |
Severity: | normal | Version: | 4.2 |
Component: | Upgrade/Install | Keywords: | has-patch |
Focuses: | Cc: |
Description
When updating plugins, I usually click "View details" before updating. But when I click "Update" from opened modal window, Shiny Updates are not used, but I am redirected from Plugins administration page. It would be nice to preserve current page, close modal window and run Shiny Updates also in this case.
Attachments (1)
Change History (18)
This ticket was mentioned in Slack in #accessibility by jorbin. View the logs.
10 years ago
#4
@
10 years ago
I'd think focus should be set to where the progress messages are shown. Does that seem logical?
#5
@
10 years ago
About focus, see similar issue faced with FTP credentials modal
#6
@
10 years ago
- Keywords has-patch added; needs-patch removed
The above patch adds support for shiny updates from the details modal window to browsers that support postMessage. Since it's an iFrame, this is the easiest method and I think we are ok not supporting below IE8 in this instance.
I set focus on the update message box. Feedback is welcome there.
This ticket was mentioned in Slack in #core by jorbin. View the logs.
10 years ago
#8
@
10 years ago
@jorbin hi,
if I'm not wrong, the "update message box" (the TR) is not focusable so targeting it with focus() won't have any effect. Focus will be lost. Firefox will keep focus "in place" but that's because Firefox tries to be clever :) with Chrome and IE focus will be lost.
Also, when "click" is triggered, the "update" link will get removed and that HTML portion rebuilt, so there's nothing to focus there. That's why in #31608 we set focus on the checkbox, maybe not nice, but I really don't know what else we could do here.
#10
@
10 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
updates-core.php also has a modal that we need to account for. We should disable it on that screen since you can't do a one off shiny update on that screen.
#12
@
10 years ago
I updated to latest trunk and does not work for me. When I click update button from plugin modal, I am redirected to standard 4.1 update page...
#13
@
10 years ago
@pavelelevap - What browser is this happening on and from which screen are you initiating the request? Is this happening from the src directory or are you using a checkout of core.[svn,git].wordpress.org? If it's a core checkout, does it persist with script_debug enabled?
#14
@
10 years ago
Browser: Chrome.
Screen: wp-admin/plugins.php
- Show details link for any outdated plugin - click to update in modal window.
I am using src
from develop.svn.wordpress.org/trunk
.
I added define('SCRIPT_DEBUG', true);
but no change.
I tried anonymous window and clearing cache.
Other hints: I am using xampp on Windows, localized version.
Thanks Pavelevap
For this, we are going to need to bind an event to the upgrade click that:
1) closes the window
2) Initiates the appropriate update.
The one thing I'm not sure of is where we should put focus when this happens.