#31763 closed defect (bug) (fixed)
Press This: do quote user selection when dealing with an oembed provider's site.
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 4.2 | Priority: | normal |
| Severity: | normal | Version: | 4.2 |
| Component: | Press This | Keywords: | has-patch dev-feedback |
| Focuses: | Cc: |
Description
We recently (#31637) made the decision to not blockquote text underneath embeds, when the source site is recognized as an oembed provider (Youtube, SoundCloud, etc).
This works when we discover a page's description (Open Graph tags, etc), but we should probably quote the text if the user went to the extent of actually selecting some in the source page (s in $_POST or $_GET).
The attached patch does this. We should also discuss if when we do so, we should also include the standard attribution link, as we do for other cases. I'd argue it's not necessary, since the embeds all have direct links to the source, but I'm opened to it.
I'm listing this as a bug because we didn't discuss it at the time, but it came up as an expectation when brought up.
User selection is deliberate enough that including it beneath the embed seems reasonable. Omitting attribution from the quote when there is an attributed embed sounds fine.