WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#31763 closed defect (bug) (fixed)

Press This: do quote user selection when dealing with an oembed provider's site.

Reported by: stephdau Owned by: azaozz
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Press This Keywords: has-patch dev-feedback
Focuses: Cc:
PR Number:

Description

We recently (#31637) made the decision to not blockquote text underneath embeds, when the source site is recognized as an oembed provider (Youtube, SoundCloud, etc).

This works when we discover a page's description (Open Graph tags, etc), but we should probably quote the text if the user went to the extent of actually selecting some in the source page (s in $_POST or $_GET).

The attached patch does this. We should also discuss if when we do so, we should also include the standard attribution link, as we do for other cases. I'd argue it's not necessary, since the embeds all have direct links to the source, but I'm opened to it.

I'm listing this as a bug because we didn't discuss it at the time, but it came up as an expectation when brought up.

Attachments (1)

31763.diff (812 bytes) - added by stephdau 5 years ago.

Download all attachments as: .zip

Change History (5)

@stephdau
5 years ago

#1 @stephdau
5 years ago

  • Summary changed from Do quote user selection when dealing with an oembed provider's site. to Press This: do quote user selection when dealing with an oembed provider's site.

#2 @ryan
5 years ago

User selection is deliberate enough that including it beneath the embed seems reasonable. Omitting attribution from the quote when there is an attributed embed sounds fine.

#3 @azaozz
5 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 31894:

Press This: on sites that support oEmbed, if the user has selected some text, quote it below the embed.
Props stephdau. Fixes #31763.

#4 @stephdau
5 years ago

Thanks Oz.

Note: See TracTickets for help on using tickets.