Opened 9 years ago
Closed 9 years ago
#31768 closed defect (bug) (fixed)
Press This: Emoji support within the title
Reported by: | ocean90 | Owned by: | azaozz |
---|---|---|---|
Milestone: | 4.2 | Priority: | low |
Severity: | normal | Version: | 4.2 |
Component: | Press This | Keywords: | |
Focuses: | javascript | Cc: |
Description
If a browser doesn't support native emojis they are replaced with an image. Since $titleField.text()
doesn't catch the HTML the placeholder will be still shown.
Attachments (2)
Change History (9)
#1
@
9 years ago
- Keywords has-patch added; needs-patch removed
Swapping out .text
for .html
all that is needed here? It seems to work for me with that change (attached).
Any downsides to this or missed edge cases?
#2
follow-up:
↓ 3
@
9 years ago
- Keywords needs-patch added; has-patch removed
- Summary changed from Press This: Remove title placeholder if emoji is an image to Press This: Emoji support within the title
Hold up on 31768.diff. Actually saving the title with emoji fails. Emoji is stripped out.
#3
in reply to:
↑ 2
@
9 years ago
Replying to kraftbj:
It is insecure too :)
Best is to use a textarea there. The bad thing about textareas is that they don't "fit" their content, i.e. don't resize to accommodate longer titles. We probably can hack that with some JS. Will solve this and other similar problems.
Another option is: we have to mimic the behavior of a form element; no replacements of emoji chars with images... Not sure which is easier/cleaner.
#4
@
9 years ago
I'd prefer we kept the h2, but I defer the decision to @azaozz. I can fix up the styles when needed, but I suspect both solutions will be messy.
Chrome 41 on OS X