WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#31776 closed defect (bug) (fixed)

I18n optimizations for 4.2

Reported by: obenland Owned by: ocean90
Milestone: 4.2 Priority: high
Severity: normal Version: 4.2
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

Ticket to collect optimization suggestions for new strings in 4.2.

Attachments (7)

31776.diff (834 bytes) - added by obenland 4 years ago.
Uppercase D to match themes.php and class-wp-customize-control.php
31776.1.diff (2.4 KB) - added by obenland 4 years ago.
Optional: Use a placeholder to be able to reorder words.
31776.2.diff (910 bytes) - added by obenland 4 years ago.
Add seconds in date format string for parity.
31776.4.diff (604 bytes) - added by obenland 4 years ago.
Context for ID placeholder
31776.5.diff (2.6 KB) - added by obenland 4 years ago.
Follow-up to 31776.1.diff
31776.3.diff (669 bytes) - added by obenland 4 years ago.
Context for placeholder
31776.patch (1.6 KB) - added by iseulde 4 years ago.

Download all attachments as: .zip

Change History (16)

@obenland
4 years ago

Uppercase D to match themes.php and class-wp-customize-control.php

@obenland
4 years ago

Optional: Use a placeholder to be able to reorder words.

@obenland
4 years ago

Add seconds in date format string for parity.

#1 @ocean90
4 years ago

  • Owner set to ocean90
  • Status changed from new to accepted

@obenland
4 years ago

Context for ID placeholder

@obenland
4 years ago

Follow-up to 31776.1.diff

@obenland
4 years ago

Context for placeholder

#2 @ocean90
4 years ago

In 31905:

Improve newly added strings for i18n:

  • Use a placeholder for the theme name to be able to reorder words.
  • Uppercase D for "Theme Details" to match existing strings.
  • Merge two revision date formats.
  • Add translator comment to strings with placeholders.

props obenland.
see #31776.

#3 @ocean90
4 years ago

In 31906:

Improve newly added strings for i18n:

  • Add context to "Format" string.
  • Use "Format" with context for "Post format".

see #31776.

This ticket was mentioned in Slack in #core by drew. View the logs.


4 years ago

#5 @ocean90
4 years ago

In 31915:

Remove a stray > introduced in [31905].

see #31776.

#6 @DrewAPicture
4 years ago

  • Priority changed from normal to high

@iseulde
4 years ago

#7 @iseulde
4 years ago

  • Keywords has-patch added

31776.patch: Merge strings that describe the same command.

This ticket was mentioned in Slack in #core by drew. View the logs.


4 years ago

#9 @ocean90
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 32078:

Merge strings that describe the same command.

props iseulde.
fixes #31776.

Note: See TracTickets for help on using tickets.