WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 17 months ago

#31783 closed defect (bug) (fixed)

In theme details modal Tags getting overlapped by action buttons

Reported by: sagarjadhav Owned by: valentinbora
Milestone: 5.5 Priority: normal
Severity: minor Version: 4.1.1
Component: Themes Keywords: has-screenshots good-first-bug
Focuses: ui, administration Cc:

Description

Go to Appearance -> Themes -> Theme Details.

In mobile devices tags getting overlapped by action buttons. This issue comes when current theme details modal opens.

I have attached screenshots taken in iPhone 6 portrait view.

http://i.imgur.com/I82aZWk.png

Attachments (3)

31783.patch (461 bytes) - added by sagarjadhav 6 years ago.
Fixed issue
Screen Shot 2020-02-14 at 4.09.33 AM.png (81.9 KB) - added by valentinbora 18 months ago.
Screen Shot 2020-02-14 at 11.24.58 AM.png (80.1 KB) - added by valentinbora 18 months ago.
With 31783.patch applied

Download all attachments as: .zip

Change History (9)

@sagarjadhav
6 years ago

Fixed issue

#1 @sagarjadhav
6 years ago

  • Keywords has-patch added

In above patch have added following styles.

.theme-overlay .theme-actions { 
    padding-left: 4%;
    padding-right: 4%; 
} 

In screen iPhone 5 portrait ( 320px ) action buttons moved to three rows and above code will fix that issue and make padding uniform with following element.

.theme-about

Please refer following image for more info.

http://i.imgur.com/kzSUcDD.png

#2 @valentinbora
18 months ago

  • Milestone set to 5.5
  • Severity changed from normal to minor

Thank you so much for reporting this @sagarjadhav and sorry for the long time to reply.

This still seems to be an issue affecting 5.3.2, 5.4 and trunk at [47289] as shown in my screenshot above.

#3 @valentinbora
18 months ago

  • Keywords has-screenshots good-first-bug added; has-patch removed

31783.patch makes it better, but it could still use some improvement in terms of bottom padding to give it some "air".

#4 @valentinbora
18 months ago

  • Owner set to valentinbora
  • Status changed from new to accepted

#5 @SergeyBiryukov
17 months ago

  • Component changed from Administration to Themes

#6 @SergeyBiryukov
17 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 47435:

Themes: Prevent tags in Theme Details modal from being partially hidden behind action buttons on smaller screens.

Props sagarjadhav, valentinbora.
Fixes #31783.

Note: See TracTickets for help on using tickets.