Plugin update gives notice

[Kloon]

When updating a plugin with the new shiny interface on the plugins page it throws a notice of undefined index.

PHP Notice: Undefined index: plugin in /srv/www/wordpress-develop/src/wp-admin/includes/update.php on line 279

[Kloon]

Make sure plugin index is set before passing it through

[Kloon]

Above patch makes sure the plugin index is set before it calls is_plugin_active

[jorbin]

Hi Kloon,

Thanks for reporting this. Which screen are you seeing this on? Is it all plugins or just some plugins? If it's some, which ones?

This may be related to #31738 and the fix there might need to be broadened.

[Kloon]

Hey @jorbin,

The only other plugin I had installed and active was query monitory which I use for debugging.

[jorbin]

@kloon

Which plugin was it that generated the notice? Query Monitor or a different one? And which screen was it on (for example plugins.php , plugins.php?plugin_status=upgrade , plugin-install.php )?

[Kloon]

@jorbin

I was testing it by setting the version number of query monitor back a version and then on plugins.php clicking the update link which triggers the ajax update by calling

update.php?action=upgrade-plugin&plugin=query-monitor%2Fquery-monitor.php&_wpnonce=

[DrewAPicture]

I can't reproduce this issue on latest trunk, though I suppose adding the isset() check couldn't hurt.

[DrewAPicture]

Closing as worksforme. Feel free to reopen if you continue to see issues.

[daronspence]

Don't know if this helps but I just saw this today as well while testing my plugins with the shiny updates.

​http://i.imgur.com/w7h0sk4.png

I think it may be related to Pippin's Software Licensing Add-on though. I'll shoot him a link to this thread.

[mordauk]

I've seen this several times now. As far as I can tell, it only happens with custom plugin updaters, but it's still a bug in core (I think).

This comment describes the cause: https://core.trac.wordpress.org/ticket/29820#comment:73

[mordauk]

31784.patch uses $file instead of $plugin_data['plugin'] since $file will always exist, even if a plugin has modified the update data.

[mordauk]

Pre-patch: ​https://cloudup.com/cgdDRO-01fZ

Post-patch: ​https://cloudup.com/cp-lYd-VVU2

[jdgrimes]

Replying to mordauk:

I've seen this several times now. As far as I can tell, it only happens with custom plugin updaters, but it's still a bug in core (I think).

This comment describes the cause: https://core.trac.wordpress.org/ticket/29820#comment:73

As a followup to my comment on the other ticket, I think that there actually was a custom plugin updater installed, but I don't recall know the exact one.

[mordauk]

Replying to jdgrimes:

Replying to mordauk:

I've seen this several times now. As far as I can tell, it only happens with custom plugin updaters, but it's still a bug in core (I think).

This comment describes the cause: https://core.trac.wordpress.org/ticket/29820#comment:73

As a followup to my comment on the other ticket, I think that there actually was a custom plugin updater installed, but I don't recall know the exact one.

That's the only time I've been able to make it happen.

[ryan]

Related?

[ryan]

I'm seeing that on every page load of plugins.php with the 4.3-alpha-32681 nightly build.

[ryan]

Replying to ryan:

I'm seeing that on every page load of plugins.php with the 4.3-alpha-32681 nightly build.

Never mind. This cleared after a fresh update.

[dd32]

This is definitely caused by a 3rd party update script not setting the expected keys. I have a feeling we might've added the plugin key at some point (a long time ago).

No harm in consistently using the same variable though.

[dd32]

In 32784:

Updates: Consistently use the same variable to refer to the plugin, avoids a potential PHP Notice when an external update script adds data without that key.
Props mordauk. Fixes #31784