Opened 10 years ago
Closed 10 years ago
#31794 closed defect (bug) (fixed)
Theme Switcher: Improve mobile experience
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.2 | Priority: | normal |
Severity: | normal | Version: | 4.2 |
Component: | Customize | Keywords: | |
Focuses: | Cc: |
Description (last modified by )
@ryan spotted some issues on mobile devices, let's fix them.
Attachments (7)
Change History (42)
#4
@
10 years ago
- Description modified (diff)
- Owner set to ocean90
- Status changed from new to assigned
#10
follow-up:
↓ 13
@
10 years ago
Remaining issues:
- iOS: Each button/input field requires two taps as soon as the themes panel is visbile. We could bind the events to
touchend
too which makes them work on the first tap, but it's hacky. It works on other screens, so why not in the Customizer? - iOS: After clicking the button "Live Preview" of a theme the theme switcher doesn't work when trying to open the section again. CSS classes are added, but the panel doesn't slide. (https://cloudup.com/iQXjUTQ7IZj)
Help appreciated!
This ticket was mentioned in Slack in #core-customize by ocean90. View the logs.
10 years ago
#13
in reply to:
↑ 10
@
10 years ago
Replying to ocean90:
- iOS: After clicking the button "Live Preview" of a theme the theme switcher doesn't work when trying to open the section again.
I got stuck in this issue the other day even after reloading the customizer, noticed that the theme switcher panel would appear if I went to preview and then back to customize. Paint issue? Position issue?
This ticket was mentioned in Slack in #core by ocean90. View the logs.
10 years ago
#15
follow-up:
↓ 17
@
10 years ago
For the second issue, the preview-only
class is not added, so you end up in the customize section instead of the preview section?
This ticket was mentioned in Slack in #core by drew. View the logs.
10 years ago
#17
in reply to:
↑ 15
@
10 years ago
Replying to iseulde:
For the second issue, the
preview-only
class is not added, so you end up in the customize section instead of the preview section?
The class is only added if you click on the Preview button. There is currently now way to toggle the preview mode after a page refresh. We can create a new ticket for this, but the main issues are in comment:10.
#18
@
10 years ago
I suspect the problem is the animation. The widget panel is also broken sometimes on iOS. Removing the animation seems to fix it.
#21
@
10 years ago
Widgets seems back to rights on my iPhone 6+ with 31794.5.patch.
The theme switcher has some issues. Tap Change. Next, tap Customize. Customize requires two taps to actuate. Tap Change again. The theme images do not load. They loaded the first time Change was tapped, but not the second time.
#22
@
10 years ago
Yeah, there still seem to be some issues with iOS Safari not recognizing a given area as actionable/active - I wonder if the double tap and disappearing screenshots may be related in a way. I'm going to go ahead and commit the removal of animation on iOS, and we will continue to investigate the other issues.
#25
follow-up:
↓ 27
@
10 years ago
The problem with the missing screenshots is that, the second time, there's only data-src
, not src
...
#26
@
10 years ago
Any progress here on diagnosing the double-tab issue? Is that and the disappearing screenshots the last remaining issues?
#27
in reply to:
↑ 25
@
10 years ago
Replying to iseulde:
The problem with the missing screenshots is that, the second time, there's only
data-src
, notsrc
...
See ticket:31793:13.
#28
@
10 years ago
31794.6.patch fixes the double tap issue for Preview and Customize buttons… Doesn't fix buttons in theme details modal.
#29
follow-up:
↓ 30
@
10 years ago
On an iPhone 6+ with .6.patch, double tap issues for Preview and Customize are resolved. I don't see any widgets regressions. That leaves, as mentioned above, the screenshots issue and double tap of the dismiss button in the theme details modal (the dismiss button is misaligned on iPhone5 and 6+, correctly aligned on Nexus 5).
This ticket was mentioned in Slack in #core by sam. View the logs.
10 years ago
#33
@
10 years ago
- Keywords needs-patch removed
@ocean90 @helen Following the last commit here, the experience seems to finally meet with expectations in iPhone 5 and 6 for me. Can we call we this fixed?
#34
follow-up:
↓ 35
@
10 years ago
Still have double tap buttons in the theme details modal header (previous/next/close) when within the theme switcher/customizer. I think it's okay to split that out and fix in point release or even 4.3 - it's definitely frustrating and I do not like to make users think that their first tap was "wrong", but I don't consider it a blocker. I drilled down into a reproducible test case for what the previous commit seems to be working around, but we can leave it the way it is now as I haven't tested the fix within the customizer and it's not inherently terrible to have it as a text input instead.
#35
in reply to:
↑ 34
@
10 years ago
- Resolution set to fixed
- Status changed from assigned to closed
Replying to helen:
Still have double tap buttons in the theme details modal header (previous/next/close) when within the theme switcher/customizer. I think it's okay to split that out and fix in point release or even 4.3 - it's definitely frustrating and I do not like to make users think that their first tap was "wrong", but I don't consider it a blocker. I drilled down into a reproducible test case for what the previous commit seems to be working around, but we can leave it the way it is now as I haven't tested the fix within the customizer and it's not inherently terrible to have it as a text input instead.
Opened #31980 for the double tap issue.
Calling this fixed for 4.2. Thanks for the work everbody!
In 31912: