WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#31796 closed defect (bug) (fixed)

TinyMCE view - rendering twice

Reported by: mattheu Owned by: azaozz
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: TinyMCE Keywords:
Focuses: javascript Cc:

Description (last modified by iseulde)

I have a query about this changeset: https://core.trac.wordpress.org/changeset/31832

The following code was removed:

if ( selected ) { 
    removeView( selected ); 
} 

The commit is a revert of [31817] and [31819] - however I'm not sure why this code was removed because it wasn't added in either of these.

This has broken the behaviour of my views - which are now rendered double if an existing view is updated.

However this issue doesn't appear to be affecting the built-in previews such as audio or gallery so it may be that I am implementing things incorrectly!

Change History (4)

#1 @helen
5 years ago

  • Milestone changed from Awaiting Review to 4.2

Moving for investigation.

#2 @iseulde
5 years ago

  • Component changed from General to TinyMCE
  • Focuses javascript added

Looks like a bit too much was removed. :)

#3 @iseulde
5 years ago

  • Description modified (diff)

#4 @azaozz
5 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 31931:

TinyMCE wpView: add back the removal of selected views on inserting new content. Was removed when reverting the first fix for embedding of pasted URLs.
Props mattheu. Fixes #31796.

Note: See TracTickets for help on using tickets.