Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #31798, comment 3


Ignore:
Timestamp:
03/29/2015 12:20:08 PM (10 years ago)
Author:
yoavf
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31798, comment 3

    initial v1  
    55Oh nice, I never saw that beore (that's what I get for sitting out of dev cycles).
    66
    7 Anyway, the regex in {{{swap-dashicons-left-right-arrows}}}  expects the values to be surrounded by double quotes, and we have (in this file, and probably other) content values surrounded by single quotes.
     7Anyway, {{{swap-dashicons-left-right-arrows}}}  expects the values to be surrounded by double quotes, and we have (in this file, and probably other) content values surrounded by single quotes.
    88
    99Should we improve the regex to catch both, or do we have a guideline on how to surround content values this way or another?