Changes between Initial Version and Version 1 of Ticket #31809, comment 4
- Timestamp:
- 06/26/2018 11:36:20 AM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #31809, comment 4
initial v1 1 1 I am hesitant about issue as reported. The function is clearly documented to accept non-nullable string in `Y-m-d H:i:s` format. Passing it `null` does not seem to be either explicitly or implicitly meaningful. 2 2 3 Returning currentdate is a case for invalid input, which ''is'' confusing as for me, but that's how it is written as of right now. I do not see how returning ''current'' time ''for invalid input'' is especially more meaningful or desired. It’s an error case. If anything it should probably fail altogether on it, but backwards compatibility.3 Returning "zero" date is a case for invalid input, which ''is'' confusing as for me, but that's how it is written as of right now. I do not see how returning ''current'' time ''for invalid input'' is especially more meaningful or desired. It’s an error case. If anything it should probably fail altogether on it, but backwards compatibility. 4 4 5 5 What are the good reasons here to change behavior in such way?
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)