WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#31816 closed defect (bug) (fixed)

Duplicate ID on menu page

Reported by: sagarjadhav's profile sagarjadhav Owned by: helen's profile helen
Milestone: 4.3 Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords: has-patch
Focuses: ui, administration Cc:

Description

Duplicate ID for Menu on "nav-menus.php". Issue found after multiple menus created.

Go to Appearance -> Menus

http://i.imgur.com/UF9LAXA.png

Attachments (2)

31816.patch​ (727 bytes) - added by sagarjadhav 9 years ago.
Fixed issue
31816.2.patch​ (708 bytes) - added by sagarjadhav 9 years ago.
Updated patch

Download all attachments as: .zip

Change History (14)

@sagarjadhav
9 years ago

Fixed issue

#1 @sagarjadhav
9 years ago

  • Component changed from General to Menus
  • Keywords has-patch added

#2 @SergeyBiryukov
9 years ago

  • Milestone changed from Awaiting Review to 4.3

This ticket was mentioned in ​Slack in #design by helen. ​View the logs.
9 years ago

#4 @helen
9 years ago

  • Keywords needs-patch added; has-patch removed

I don't think that hidden input needs an ID at all.

@sagarjadhav
9 years ago

Updated patch

#5 @sagarjadhav
9 years ago

  • Keywords has-patch added; needs-patch removed

I agree with you helen, as hidden input don't need ID. I have updated patch with mentioned change. Hope this fine now.

#6 @helen
9 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 32695:

Nav menus: Hidden inputs do not need an ID, especially one that's already in use.

props sagarjadhav.
fixes #31816.

#7 @ahmed daoud
9 years ago

  • Version changed from 4.1.1 to trunk

#8 @ahmed daoud
9 years ago

hi.thank you for help me

#9 @SergeyBiryukov
9 years ago

  • Version changed from trunk to 3.0

Introduced in [13257] as menu_id_in_edit, changed to menu-id-in-edit in [13375], then to menu in [13704].

#10 @ocean90
9 years ago

Follow-up: #32699

#11 @obenland
9 years ago

In 33161:

Nav menus: Restore menu id in hidden input.

wp-admin/js/nav-menu.js uses the value as context for quick searches and when
adding menu items.

Reverts [32695], see #31816.
Fixes #32699.

#12 @ocean90
9 years ago

In 33174:

Nav menus: Add an ID attribute to the menu select box to link it with the label.

see #31816.
fixes #32699.

Note: See TracTickets for help on using tickets.