WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#31828 closed enhancement (invalid)

Dashboard close button

Reported by: Luan Ramos Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.1
Component: Administration Keywords:
Focuses: ui, administration Cc:

Description (last modified by SergeyBiryukov)

When the screen is the size mobile, include this code.

The text need only disappear when with smaller screen size;

.welcome-panel .welcome-panel-close { 
  font-size: 0; 
}

Attachments (2)

resize.png (34.5 KB) - added by Luan Ramos 5 years ago.
31828.patch (466 bytes) - added by sagarjadhav 5 years ago.
Fixed issue

Download all attachments as: .zip

Change History (20)

@Luan Ramos
5 years ago

#1 @SergeyBiryukov
5 years ago

  • Description modified (diff)
  • Focuses accessibility template removed

@sagarjadhav
5 years ago

Fixed issue

#2 @sagarjadhav
5 years ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #core by luanramos. View the logs.


5 years ago

This ticket was mentioned in Slack in #core by luanramos. View the logs.


5 years ago

#5 @DrewAPicture
5 years ago

  • Type changed from defect (bug) to enhancement

This ticket was mentioned in Slack in #core by luanramos. View the logs.


5 years ago

This ticket was mentioned in Slack in #core by luanramos. View the logs.


5 years ago

This ticket was mentioned in Slack in #core by luanramos. View the logs.


5 years ago

#9 @chriscct7
5 years ago

  • Keywords ui-feedback added
  • Version changed from 4.1.1 to 4.1

#10 follow-ups: @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 4.3

Seems like we should either fix the positioning or add display: none. font-size: 0 doesn't make sense to me.

#11 in reply to: ↑ 10 ; follow-up: @chriscct7
5 years ago

  • Keywords reporter-feedback added

Replying to SergeyBiryukov:

Seems like we should either fix the positioning or add display: none. font-size: 0 doesn't make sense to me.

I would agree. However I can't replicate this bug. There already is a mobile query that hides the text, and I've been testing the breakpoints for the last 5 minutes and can't replicate this.

What size screen is that?

#12 @chriscct7
5 years ago

The breakpoint to hide the text is at 580px. At 579px, the text and some of the admin menu bar items are hidden

#13 in reply to: ↑ 11 @afercia
5 years ago

Replying to chriscct7:

I would agree. However I can't replicate this bug.

Fixed in r32475.

#14 @Luan Ramos
5 years ago

Resize window and show bug.

This ticket was mentioned in Slack in #core by luanramos. View the logs.


5 years ago

#16 in reply to: ↑ 10 @Luan Ramos
5 years ago

Replying to SergeyBiryukov:

Seems like we should either fix the positioning or add display: none. font-size: 0 doesn't make sense to me.

When you resize the browser window to 600px, we find the error. button text should hide in resolution less than 600px. We could use an average wanted to fix this. agree ?

Thank you!

#17 @chriscct7
5 years ago

  • Keywords has-patch ui-feedback removed
  • Milestone changed from 4.3 to Future Release

Unless we can replicate the behavior, we can't fix it. Shouldn't be milestoned till it can be easily replicated.

@launramos, this bug appears to have already been fixed 2 weeks ago. Are you testing on trunk, not 4.2.2?

#18 @chriscct7
5 years ago

  • Keywords reporter-feedback removed
  • Milestone Future Release deleted
  • Resolution set to invalid
  • Status changed from new to closed

This was fixed in #32287 and committed to trunk 2 weeks ago in r32475, as @afercia pointed out. Closing as invalid.

Note: See TracTickets for help on using tickets.