Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#31829 closed enhancement (fixed)

Change Customizer "Display Site Title" text

Reported by: vlad.olaru Owned by: juanfra
Priority: normal Milestone: 4.5
Component: Customize Version: 3.4
Severity: normal Keywords: good-first-bug has-patch
Cc: Focuses: ui

Description

We should change this text to something like "Display Site Title & Tagline" to make it clearer to users that is meant to affect both.

Attachments (5)

orig.jpg (10.3 KB ) - added by voldemortensen 11 years ago.
Current text.
changed.jpg (11.0 KB ) - added by voldemortensen 11 years ago.
Proposed text.
.DS_Store (6.0 KB ) - added by juanfra 11 years ago.
Diff file: Replaced 'Display Header Text' with 'Display Site Title & Tagline'
31829.diff (583 bytes ) - added by juanfra 11 years ago.
Diff file: Replaced 'Display Header Text' with 'Display Site Title & Tagline'
31829-and.diff (585 bytes ) - added by juanfra 11 years ago.
Just in case, the patch containing "and" instead of the ampersand.

Download all attachments as: .zip

Change History (18)

#1 @voldemortensen
11 years ago

The current text, at least for the translation I am using, is "Display Header Text" which does imply both. Are you using a different translation than en_US?

Uploading screenshots for reference.

@voldemortensen
11 years ago

Current text.

@voldemortensen
11 years ago

Proposed text.

#2 @vlad.olaru
11 years ago

Glad to see the proposed text. "header text" is a too technical way of saying it :)

#3 @jorbin
11 years ago

  • Keywords ux-feedback added
  • Milestone Awaiting ReviewFuture Release

Strings are frozen for 4.2 as of beta 4, so putting this in Future Release.

#4 @iseulde
11 years ago

  • Version trunk

#5 @celloexpressions
11 years ago

  • Version3.4

This is partially dependent on exactly the theme choses to use these, but this alternative text would probably help there.

#6 @karmatosed
11 years ago

+1 for the alternative text, great suggestion @vlad.olaru. If you look at the customizer for example it is really needing a better description.

https://cldup.com/WUO5hfnx1u.png

#7 @celloexpressions
11 years ago

  • Focuses ui added
  • Keywords good-first-bug needs-patch added; ux-feedback removed

Seems like there's consensus on changing it to "Display site title and tagline". This should be an easy string change in wp-includes/class-wp-customize-manager.php if anyone is interested in trying their hand at a first patch.

#9 @SergeyBiryukov
11 years ago

  • Milestone Future Release4.5

@juanfra
11 years ago

Diff file: Replaced 'Display Header Text' with 'Display Site Title & Tagline'

@juanfra
11 years ago

Diff file: Replaced 'Display Header Text' with 'Display Site Title & Tagline'

#10 @juanfra
11 years ago

Sorry for the first file. Wrong pick. Let me know if you prefer 'and' instead of the ampersand.

Last edited 11 years ago by juanfra (previous) (diff)

@juanfra
11 years ago

Just in case, the patch containing "and" instead of the ampersand.

#11 @SergeyBiryukov
11 years ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to juanfra
  • Status newassigned

Assigning to mark the good-first-bug "claimed".

@juanfra Thanks for the patch!

#12 @juanfra
11 years ago

@SergeyBiryukov my pleasure :)

#13 @SergeyBiryukov
11 years ago

  • Resolutionfixed
  • Status assignedclosed

In 35899:

Customizer: Change "Display Header Text" checkbox label to "Display Site Title and Tagline", to make it clearer that it affects both settings.

Props juanfra, vlad.olaru.
Fixes #31829.

Note: See TracTickets for help on using tickets.