WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#31835 closed defect (bug) (wontfix)

Merge the subdomain/subdirectory translation strings

Reported by: ramiy Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: administration, multisite Cc:

Description

See the attached patch.

I've merged the two translation strings to one string, and I've moved the logic to the code.

Merging the strings makes the PO/MO file smaller. And if you see the new code - it's just more logical.

Attachments (1)

31835.patch (1.3 KB) - added by ramiy 6 years ago.

Download all attachments as: .zip

Change History (8)

@ramiy
6 years ago

#1 follow-ups: @SergeyBiryukov
6 years ago

  • Component changed from General to Networks and Sites
  • Focuses administration multisite added

I think someone might want to translate site1/site2.

#2 in reply to: ↑ 1 @ramiy
6 years ago

  • Version set to trunk

Sergey, it's your call.

From cost effectiveness point of view I prefer a smaller PO/MO file, to make my site faster few more micro-seconds.

#3 @ramiy
6 years ago

  • Keywords has-patch added

#5 @SergeyBiryukov
6 years ago

  • Component changed from Networks and Sites to I18N

#6 @DrewAPicture
6 years ago

  • Version trunk deleted

#7 in reply to: ↑ 1 @ocean90
5 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Replying to SergeyBiryukov:

I think someone might want to translate site1/site2.

Currently it's translated in 30 languages. Closing as wontfix.

Note: See TracTickets for help on using tickets.