WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#31837 closed defect (bug) (fixed)

Customizer Theme Switcher: Remove "Add New" references

Reported by: helen Owned by: ocean90
Milestone: 4.2 Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-patch commit
Focuses: ui Cc:

Description

Since the theme switcher is essentially a straight port of the themes screen to the customizer, the Add New button as well as bottom theme item for adding a new one appear inside the customizer (in non-multisite). This takes you out of the customizer context without warning, which isn't great UX and doesn't really fit into the flows targeted by this particular UI. Let's remove them for this iteration.

Attachments (1)

31837.patch (2.4 KB) - added by ocean90 4 years ago.

Download all attachments as: .zip

Change History (9)

#1 @siobhan
4 years ago

+100

I did this earlier and it was a confusing experience. It'd be even moreso if you've done lots of customization.

#2 @michaelbeil
4 years ago

Agreed.

@ocean90
4 years ago

#3 @ocean90
4 years ago

  • Keywords has-patch commit added; needs-patch removed

#4 follow-up: @celloexpressions
4 years ago

  • Keywords needs-patch added; has-patch commit removed

While it's not the best solution, you should get an AYS before it loads, and I think it's really important to have a clear path to adding a new theme from this workflow for discoverability. New users are not likely to realize that they can install other themes besides the bundled ones if it's not in this flow, as they may never hit the themes admin page if they go through a more customizer-oriented flow.

The flow isn't as integrated as I'd like, but adding a new theme from this flow if you decided that none of the installed themes work is still a valid use case that I think we should support clearly, rather than having to close the Customizer, dig through the admin first going to the themes screen then add new. You move from one click/page load to add a new theme to at least three (four if you accessed the Customizer from the front end).

#5 in reply to: ↑ 4 ; follow-up: @helen
4 years ago

  • Keywords has-patch commit added; needs-patch removed

Replying to celloexpressions:

There are many flow pain points that are far more critical to keeping this feature in 4.2 than this. A link to add new is not critical to keeping this feature, and we can continue to iterate in future releases. We are nowhere near an all-customizer flow, and realistically we haven't even defined that as a set goal. Creating understanding of how theme installation works isn't going to start here.

#6 in reply to: ↑ 5 @celloexpressions
4 years ago

Replying to helen:

Replying to celloexpressions:

There are many flow pain points that are far more critical to keeping this feature in 4.2 than this. A link to add new is not critical to keeping this feature, and we can continue to iterate in future releases. We are nowhere near an all-customizer flow, and realistically we haven't even defined that as a set goal. Creating understanding of how theme installation works isn't going to start here.

I'm more worried about understanding the existence of theme-install, and havingg a dead end when none of the installed themes fit what they're looking like. I think we need to address the fact that this would go from a one-click flow to a three-to-four-click flow, and is a logical flow to have, before commit. Just because it isn't all-customizer doesn't mean that it won't be a high use case thing. I'd also like to see user tests before we make that type of a decision/change. While exiting the Customizer isn't ideal, the alternative seems far worse. That being said, I'd be totally fine with only one add-new button, probably the one at the end of the themes list would be better, and the other could be removed.

#7 @ocean90
4 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 31968:

Customizer Theme Switcher: Remove "Add New" references.

The current iteration takes you out of the customizer context, which isn't great UX and doesn't really fit into the flows targeted by this particular UI.

fixes #31837.

#8 @ocean90
4 years ago

In 32004:

Customizer Theme Switcher: Remove "Add New" reference from customize-controls.js.

see #31837.

Note: See TracTickets for help on using tickets.