WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#31845 closed defect (bug) (fixed)

Not enough padding on bottom of image setting boxes on edit media screen

Reported by: jdgrimes Owned by: helen
Milestone: 4.3 Priority: normal
Severity: normal Version: 3.9
Component: Media Keywords: has-patch
Focuses: ui, administration Cc:
PR Number:

Description

When editing an image on the attachment's Edit Media screen, there needs to be more padding at the bottom of the Image Crop and Thumbnail Settings boxes.

See attached screenshot.

Attachments (6)

not-enough-padding.png (56.9 KB) - added by jdgrimes 5 years ago.
image_edit_38.png (93.5 KB) - added by DrewAPicture 5 years ago.
3.8
image_edit_39.png (75.1 KB) - added by DrewAPicture 5 years ago.
3.9
31845.patch (582 bytes) - added by tyxla 5 years ago.
Fixing paddings & margins on edit media meta boxes.
Screen Shot 2015-06-30 at 4.22.51 PM.png (1.5 MB) - added by ryan 4 years ago.
After
Screen Shot 2015-06-30 at 4.25.14 PM.png (1.4 MB) - added by ryan 4 years ago.
Before

Change History (14)

@DrewAPicture
5 years ago

3.8

@DrewAPicture
5 years ago

3.9

#1 @DrewAPicture
5 years ago

  • Keywords needs-patch added
  • Version changed from trunk to 3.9

The problem seems to have been introduced in 3.9. See image_edit_38.png and image_edit_39.png for comparison.

@tyxla
5 years ago

Fixing paddings & margins on edit media meta boxes.

#2 @tyxla
5 years ago

  • Keywords has-patch added; needs-patch removed

#3 @tyxla
5 years ago

Just added a patch that takes care of these.
Looks fine in both media edit page and media edit in modal.
This solution will work for custom / future meta boxes as well, as the spacing comes from the boxes themselves, and not from their internal content.

#4 @helen
5 years ago

  • Keywords 4.3-early added

#5 @obenland
4 years ago

  • Owner set to helen
  • Status changed from new to assigned

#6 @obenland
4 years ago

  • Keywords 4.3-early removed
  • Milestone changed from Awaiting Review to 4.3

This ticket was mentioned in Slack in #core by helen. View the logs.


4 years ago

#8 @helen
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33002:

Image edit: Consistent whitespace for the side boxes.

props tyxla.
fixes #31845.

Note: See TracTickets for help on using tickets.