WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#31849 closed defect (bug) (fixed)

Fix wrong use of __x()

Reported by: ramiy's profile ramiy Owned by: ocean90's profile ocean90
Milestone: 4.3 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: multisite Cc:

Description (last modified by ocean90)

Should be __()

Attachments (2)

31849.patch​ (786 bytes) - added by ramiy 11 years ago.
31849.2.patch​ (805 bytes) - added by ramiy 11 years ago.

Download all attachments as: .zip

Change History (8)

@ramiy
11 years ago

#1 @boonebgorges
11 years ago

  • Summary changed from Fix wrong use of __e() to Fix wrong use of __x()

#2 follow-up: @ocean90
11 years ago

  • Component changed from General to I18N
  • Description modified (diff)
  • Focuses multisite added
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to Future Release

_x() is actually correct since it has a context: '%1$s: site name. %2$s: site tagline.', But yeah, it should be moved to a translator comment and __().

#3 in reply to: ↑ 2 @ramiy
11 years ago

You are right, I'll update my patch.

@ramiy
11 years ago

#4 @iseulde
11 years ago

  • Version trunk deleted

#5 @ocean90
11 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 32472:

Sites List Table: Replace context with a translators comment for the site name and tagline.

props ramiy.
fixes #31849.

#6 @ocean90
11 years ago

  • Milestone changed from Future Release to 4.3
Note: See TracTickets for help on using tickets.