Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#31852 closed defect (bug) (fixed)

Avoid using <code> in translation strings (wp-admin/options-general.php)‎

Reported by: ramiy's profile ramiy Owned by: wonderboymusic's profile wonderboymusic
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

Attachments (2)

31852.patch (1.7 KB) - added by ramiy 10 years ago.
31852.2.patch (1.8 KB) - added by SergeyBiryukov 10 years ago.

Download all attachments as: .zip

Change History (11)

@ramiy
10 years ago

#1 @SergeyBiryukov
10 years ago

  • Component changed from General to I18N

#2 @DrewAPicture
10 years ago

  • Version trunk deleted

This ticket was mentioned in Slack in #polyglots by ramiy. View the logs.


10 years ago

#4 follow-up: @SergeyBiryukov
10 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.4

Now that we have better fuzzy matching, I guess it's time to handle this and other tickets.

Refreshed the patch. Not sure if we should also add translator comments for all placeholders as we go, or just for the ones that are not clear from the context.

I've found a lot of placeholders without comments, e.g. in a similar string in user-edit.php.

Will wait for Dominik's return next week to coordinate the changes.

Last edited 10 years ago by SergeyBiryukov (previous) (diff)

#5 in reply to: ↑ 4 @ramiy
10 years ago

Replying to SergeyBiryukov:

Not sure if we should also add translator comments for all placeholders as we go, or just for the ones that are not clear from the context.

If we already fixing the strings, let's add translator comments. I don't know when we will be the next time we fix those string.

#6 @wonderboymusic
10 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to assigned

#7 @wonderboymusic
10 years ago

  • Owner changed from SergeyBiryukov to wonderboymusic

#8 @wonderboymusic
10 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 34294:

Don't use <code> in translation strings in options-general.php.

Props ramiy, SergeyBiryukov.
Fixes #31852.

#9 @SergeyBiryukov
10 years ago

In 34300:

Add missing translator comments after [34294].

See #31852.

Note: See TracTickets for help on using tickets.