Make WordPress Core

Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#31852 closed defect (bug) (fixed)

Avoid using <code> in translation strings (wp-admin/options-general.php)‎

Reported by: ramiy Owned by: wonderboymusic
Priority: normal Milestone: 4.4
Component: I18N Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

Attachments (2)

31852.patch​ (1.7 KB ) - added by ramiy 12 years ago.
31852.2.patch​ (1.8 KB ) - added by SergeyBiryukov 11 years ago.

Download all attachments as: .zip

Change History (11)

@ramiy
12 years ago

#1 @SergeyBiryukov
12 years ago

  • Component General → I18N

#2 @DrewAPicture
12 years ago

  • Version trunk

This ticket was mentioned in ​Slack in #polyglots by ramiy. ​View the logs.


12 years ago

#4 follow-up: @SergeyBiryukov
11 years ago

  • Keywords has-patch added
  • Milestone Awaiting Review → 4.4

Now that we have better fuzzy matching, I guess it's time to handle this and other tickets.

Refreshed the patch. Not sure if we should also add translator comments for all placeholders as we go, or just for the ones that are not clear from the context.

I've found a lot of placeholders without comments, e.g. in a similar string​ in user-edit.php.

Will wait for Dominik's return next week to coordinate the changes.

Last edited 11 years ago by SergeyBiryukov (previous) (diff)

#5 in reply to: ↑ 4 @ramiy
11 years ago

Replying to SergeyBiryukov:

Not sure if we should also add translator comments for all placeholders as we go, or just for the ones that are not clear from the context.

If we already fixing the strings, let's add translator comments. I don't know when we will be the next time we fix those string.

#6 @wonderboymusic
11 years ago

  • Owner set to SergeyBiryukov
  • Status new → assigned

#7 @wonderboymusic
11 years ago

  • Owner changed from SergeyBiryukov to wonderboymusic

#8 @wonderboymusic
11 years ago

  • Resolution → fixed
  • Status assigned → closed

In 34294:

Don't use <code> in translation strings in options-general.php.

Props ramiy, SergeyBiryukov.
Fixes #31852.

#9 @SergeyBiryukov
11 years ago

In 34300:

Add missing translator comments after [34294].

See #31852.

Note: See TracTickets for help on using tickets.