WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#31853 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (wp-admin/edit-form-comment.php)‎

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: I18N Keywords:
Focuses: Cc:

Description


Attachments (2)

31853.patch​ (927 bytes) - added by ramiy 9 years ago.
31853.2.patch​ (1.7 KB) - added by ramiy 9 years ago.
update file

Download all attachments as: .zip

Change History (11)

@ramiy
9 years ago

#1 @ocean90
9 years ago

Looks like you have attached the wrong patch, it's for wp-admin/edit-form-comment.php.

@ramiy
9 years ago

update file

#2 @ramiy
9 years ago

my mistake...

it was the right file.

but wrong title.

i did copy&paste from ticket 31852 without changing the file name in the title.

#3 @ramiy
9 years ago

  • Summary changed from Avoid using HTML tags in translation strings (wp-admin/options-general.php)‎ to Avoid using HTML tags in translation strings (wp-admin/edit-form-comment.php)‎

#4 @ramiy
9 years ago

And use the first patch, not the second.

#5 @DrewAPicture
9 years ago

  • Version trunk deleted

This ticket was mentioned in ​Slack in #polyglots by ramiy. ​View the logs.
9 years ago

#7 @wonderboymusic
9 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner set to SergeyBiryukov
  • Status changed from new to assigned

#8 @wonderboymusic
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 34295:

Don't use <code> in translation strings in edit-form-comment.php.

Props ramiy.
Fixes #31853.

#9 @SergeyBiryukov
9 years ago

In 34301:

Add missing translator comment after [34295].

See #31853.

Note: See TracTickets for help on using tickets.