#31858 closed defect (bug) (fixed)
Avoid using HTML tags in translation strings (wp-admin/edit-form-advanced.php)
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | I18N | Keywords: | has-patch needs-testing 2nd-opinion |
Focuses: | Cc: |
Description
Attachments (3)
Change History (17)
This ticket was mentioned in Slack in #polyglots by ramiy. View the logs.
10 years ago
#5
@
10 years ago
What about RTL?
For the last four years I'm translating WordPress to Hebrew (he_IL), It's an RTL language.
I see no problem in splitting those strings. The strings will be presented one after the other. First the action result and then the link.
Do you see a problem with other RTL languages?
#6
@
10 years ago
No, I am not familiar with RTL :-)
But I thought that RTL use first link and second text (different order)?
I understand that these strings can be splitted and HTML removed, but in this case we are limiting translators freedom. No problem for our language, only my feeling :-)
#7
@
10 years ago
Pavel,
- I've spoken to friend, he speaks Arabic language - same answer. The patch splits the string into two sentences - first we show the action result and then the link to the post.
- This patch is a part of set of tickets to avoid HTML tags in translation strings: #31840, #31852, #31853, #31855, #31856, #31857, #31858, #31859, #31860, #31861, #31862, #31863, #31864, #31867, #31868, #31870, #31871.
- This string split, is not actually a split. Some of the new string already exist in other places in the code. For example:
- "Post updated." - exist in wp-admin/edit-form-advanced.php:84
- "Page updated." - exist in wp-admin/edit-form-advanced.php:100
- "View post" - exist in wp-includes/post.php:1637
- From my perspective, the "translators freedom" you are talking about, is to make the translation work easier. It's very hard to translate strings with HTML code because the string is in hebrew and the code is in english. With RTL it's even harder, When the code is in RTL it's very confusing. This is why I'm trying to promote this issue to avoid using HTML tags in translation strings.
#8
@
9 years ago
- Milestone changed from Awaiting Review to 4.4
- Owner set to SergeyBiryukov
- Status changed from new to assigned
#10
@
9 years ago
- Owner changed from wonderboymusic to SergeyBiryukov
needs to be reconciled with #17609
Note: See
TracTickets for help on using
tickets.
I do not think it is a good idea to split these strings, because of RTL for example?