WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#31860 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (wp-admin/includes/class-wp-upgrader-skins.php)‎

Reported by: ramiy's profile ramiy Owned by: ocean90's profile ocean90
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: I18N Keywords: needs-patch
Focuses: Cc:

Description


Attachments (1)

31860.patch​ (1.1 KB) - added by ramiy 10 years ago.

Download all attachments as: .zip

Change History (11)

@ramiy
10 years ago

#1 @ramiy
10 years ago

  • Keywords has-patch needs-testing added

#2 @DrewAPicture
10 years ago

  • Version trunk deleted

This ticket was mentioned in ​Slack in #polyglots by ramiy. ​View the logs.
10 years ago

#4 @wonderboymusic
10 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner set to SergeyBiryukov
  • Status changed from new to assigned

#5 @wonderboymusic
10 years ago

  • Keywords needs-refresh added; needs-testing removed

needs a translator string

#6 @ramiy
10 years ago

@wonderboymusic no translator string needed in this patch.

Those are __() strings, not sprintf().

They are added using the add_strings() method, and echoed in other places - see after() method.

Seems like each sprintf() has it's own parameters passed to those strings.

What I'm trying to say, this patch can be committed as it is.

#7 @ocean90
10 years ago

  • Keywords needs-patch added; has-patch needs-refresh removed
  • Owner changed from SergeyBiryukov to ocean90

This needs another approach.

#8 @ramiy
10 years ago

what do you suggest?

#9 @ocean90
10 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 34352:

Upgrader: Avoid using an HTML tag in a translation string, add translator comments.

Props ramiy for initial patch.
Fixes #31860.

#10 @ramiy
10 years ago

Very nice!

Note: See TracTickets for help on using tickets.