WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#31870 closed defect (bug) (fixed)

Avoid using HTML in translation string (wp-includes/user-functions.php)

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

Related: #31862

Move the <strong> & </strong> HTML tags out of the translation string. and add translator comments.

Attachments (4)

31870.patch (895 bytes) - added by ramiy 5 years ago.
31870.diff (1.0 KB) - added by wonderboymusic 5 years ago.
lost-your-password-string.png (43.5 KB) - added by ramiy 5 years ago.
31870.2.patch (1.5 KB) - added by ramiy 5 years ago.

Download all attachments as: .zip

Change History (15)

@ramiy
5 years ago

#1 @ramiy
5 years ago

  • Keywords has-patch added

#2 @DrewAPicture
5 years ago

  • Version trunk deleted

This ticket was mentioned in Slack in #polyglots by ramiy. View the logs.


5 years ago

#4 @wonderboymusic
5 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner set to SergeyBiryukov
  • Status changed from new to assigned

#5 @wonderboymusic
5 years ago

  • Owner changed from SergeyBiryukov to wonderboymusic

#6 follow-up: @wonderboymusic
5 years ago

  • Owner changed from wonderboymusic to SergeyBiryukov

@ramiy seems like there is more HTML in here than your other patches?

@wonderboymusic
5 years ago

#7 in reply to: ↑ 6 @ramiy
5 years ago

  • Keywords dev-feedback added

Replying to wonderboymusic:

@ramiy seems like there is more HTML in here than your other patches?

That's a good point.

I think that it would be smarter if we separate the "Lost your password?" into a separate string. See the attached screenshot.

#9 @wonderboymusic
5 years ago

  • Keywords needs-patch added; has-patch dev-feedback removed

@ramiy
5 years ago

#10 @ramiy
5 years ago

  • Keywords has-patch added; needs-patch removed
  • Summary changed from Avoid using HTML in translation string (wp-includes/user.php) to Avoid using HTML in translation string (wp-includes/user-functions.php)

#11 @ocean90
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 34354:

Login: Move the "Lost your password?" link into a separate string to reduce HTML tags in translation strings.

Props ramiy.
Fixes #31870.

Note: See TracTickets for help on using tickets.