Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#31874 closed defect (bug) (fixed)

Media error styling isn't consistent with other notices

Reported by: helen's profile helen Owned by: helen's profile helen
Milestone: 4.3 Priority: normal
Severity: normal Version:
Component: Media Keywords: good-first-bug has-patch
Focuses: ui, administration Cc:

Description

Now that we have more generically usable notices (#27418) and they are dismissible (#31233), we should make the media upload error notices visually consistent. See attached screenshots for the current (4.2-beta) state.

Attachments (5)

Screen Shot 2015-04-02 at 6.57.18 PM.png (167.7 KB) - added by helen 9 years ago.
Media modal
Screen Shot 2015-04-02 at 6.55.09 PM.png (12.8 KB) - added by helen 9 years ago.
Media library
Screen Shot 2015-04-02 at 7.03.32 PM.png (6.8 KB) - added by helen 9 years ago.
Example existing error notice
31874.patch (2.9 KB) - added by sagarjadhav 9 years ago.
Fixed Issue
31874.2.patch (3.2 KB) - added by sagarjadhav 9 years ago.
Updates with given suggestions

Download all attachments as: .zip

Change History (14)

@helen
9 years ago

Media library

@helen
9 years ago

Example existing error notice

@sagarjadhav
9 years ago

Fixed Issue

#1 @sagarjadhav
9 years ago

  • Keywords has-patch added; needs-patch removed

Following are screenshot after changes.

Insert Media

http://i.imgur.com/uPskL4X.png

Uploads in Media Library

http://i.imgur.com/nYIIBQb.png

#2 @HeadOnFire
9 years ago

@sagarjadhav I'm pretty sure that red 'Error' button is off the style. The red border-left is enough.

#3 @afercia
9 years ago

+1 for removing the red "button" :)

#4 @melchoyce
9 years ago

+1 for removing the "error" label.

I'd also bold the filename.

#5 @sagarjadhav
9 years ago

I have removed 'Error' label as suggested by @HeadOnFire and made file name bold. Let me your thought.

Following are screenshots.
http://i.imgur.com/5IycZoD.jpg

http://i.imgur.com/LHd1GdW.jpg

@sagarjadhav
9 years ago

Updates with given suggestions

#6 @helen
9 years ago

  • Milestone changed from Future Release to 4.3

#7 @helen
9 years ago

I was originally thinking of re-using the notice class names but given that this has front-end context as well, I think this is the right route for now.

#8 @helen
9 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 32506:

Media: Visually align upload errors with other admin notices.

props sagarjadhav.
fixes #31874.

#9 @helen
9 years ago

In 32508:

Autoprefixer for [32506]. see #31874.

Note: See TracTickets for help on using tickets.