Shouldn't use deprecated functions start_wp

[foolswisdom]

Continuing ticket:3186 by Nazgul for remaining deprecated function start_wp

Here's a list of the functions (and between brackets the files that use them):

start_wp (wp-atom.php, wp-rss.php, wp-rss2.php, wp-admin/edit.php, wp-admin/export.php, wp-content/themes/clasdic/comment-popup.php and wp-content/themes/default/comment-popup.php)

[westi]

I'm working on this.

[westi]

Deprecate start_wp

[westi]

Attached patch deprecates start_wp in all the listed places.

Also extends WP_Query to support post_type = all so as to enable using it for the exporter query.

Please test and feedback

[ryan]

(In [4465]) Don't use deprecated start_wp(). Props westi. fixes #3188

[ryan]

Didn't include the export changes since the exporter needs to export posts of any status and not just publish.

[westi]

Replying to ryan:

Didn't include the export changes since the exporter needs to export posts of any status and not just publish.

I tried to fix this with the new query var for post_type=all I guess i missed the post_status check as well.

I'll try and put up a patch to fix that one last occurrence by extending wp query to give us a way of getting every post/page back whatever the type /status

[westi]

Kill off the final start_wp call

[westi]

Attached patch fixes the exporter to use the API and kills off start_wp for good

[matt]

Wouldn't this allow someone to put export in the query string on someone's blog or RSS feed and grab the whole thing?

[westi]

Replying to matt:

Wouldn't this allow someone to put export in the query string on someone's blog or RSS feed and grab the whole thing?

Well post_type is a private query var (​http://trac.wordpress.org/browser/trunk/wp-includes/classes.php#L6).

I'm not entirely sure how that affects where or not it is allowed in the url without spending more time reading the code.

However it probably should.

[ryan]

(In [6077]) Use setup_postdata instead of deprecated start_wp. fixes #3188

[ryan]

I simply changed it to use setup_postdata() instead of start_wp(). All we needed from start_wp was the postdata setup.