WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #31885


Ignore:
Timestamp:
04/04/2015 06:05:26 AM (5 years ago)
Author:
westonruter
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31885 – Description

    initial v1  
    11When a widget is updated in the Customizer, the form values are serialized and sent via Ajax to pass through the widget's update callback. The widget form with the sanitized values is then sent in the Ajax response. The form inputs in the Ajax response are then copied over from the response into the existing form. This sync logic, however, does not account for the special case of `select[multiple]` inputs which lack a single `value` to synchronize: the value to synchronize is an array of zero or more values.
    22
    3 The issue with synchronizing the `selected` state among a `select[multiple] option` elements is particularly evident when the widget's underlying setting is changed programmatically, as opposed to direct user input. Here is a demonstration of the issue by using a widget undo/redo feature: https://cloudup.com/cuSHMWiSgdM
     3The issue with synchronizing the `selected` state among a `select[multiple] option` elements is particularly evident when the widget's underlying setting is changed programmatically, as opposed to direct user input. Here is a demonstration of the issue by using a widget undo/redo feature: https://cloudup.com/i7oo4v3X0v6
     4
     5Plugin used in demo is attached to ticket.
    46
    57Big props to [https://github.com/davidlonjon davidlonjon] for discovering this issue and suggesting a fix.